From: Vincent Guittot <vincent.guittot@linaro.org>
To: Qais Yousef <qyousef@layalina.io>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
linux-kernel@vger.kernel.org,
Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [PATCH v6 3/4] sched/topology: Remove max_cpu_capacity from root_domain
Date: Fri, 23 Feb 2024 10:31:56 +0100 [thread overview]
Message-ID: <CAKfTPtAvmMFL355zrqCebZJg6Su-V_um4X-c629cOJoS09-fdQ@mail.gmail.com> (raw)
In-Reply-To: <20240220225622.2626569-4-qyousef@layalina.io>
On Tue, 20 Feb 2024 at 23:56, Qais Yousef <qyousef@layalina.io> wrote:
>
> The value is no longer used as we now keep track of max_allowed_capacity
> for each task instead.
>
> Signed-off-by: Qais Yousef <qyousef@layalina.io>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
> ---
> kernel/sched/sched.h | 2 --
> kernel/sched/topology.c | 13 ++-----------
> 2 files changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index e85976bd2bab..bc9e598d6f62 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -917,8 +917,6 @@ struct root_domain {
> cpumask_var_t rto_mask;
> struct cpupri cpupri;
>
> - unsigned long max_cpu_capacity;
> -
> /*
> * NULL-terminated list of performance domains intersecting with the
> * CPUs of the rd. Protected by RCU.
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 1505677e4247..a57c006d2923 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -2513,16 +2513,9 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att
> /* Attach the domains */
> rcu_read_lock();
> for_each_cpu(i, cpu_map) {
> - unsigned long capacity;
> -
> rq = cpu_rq(i);
> sd = *per_cpu_ptr(d.sd, i);
>
> - capacity = arch_scale_cpu_capacity(i);
> - /* Use READ_ONCE()/WRITE_ONCE() to avoid load/store tearing: */
> - if (capacity > READ_ONCE(d.rd->max_cpu_capacity))
> - WRITE_ONCE(d.rd->max_cpu_capacity, capacity);
> -
> cpu_attach_domain(sd, d.rd, i);
>
> if (lowest_flag_domain(i, SD_CLUSTER))
> @@ -2536,10 +2529,8 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att
> if (has_cluster)
> static_branch_inc_cpuslocked(&sched_cluster_active);
>
> - if (rq && sched_debug_verbose) {
> - pr_info("root domain span: %*pbl (max cpu_capacity = %lu)\n",
> - cpumask_pr_args(cpu_map), rq->rd->max_cpu_capacity);
> - }
> + if (rq && sched_debug_verbose)
> + pr_info("root domain span: %*pbl\n", cpumask_pr_args(cpu_map));
>
> ret = 0;
> error:
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-02-23 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 22:56 [PATCH v6 0/4] sched: Don't trigger misfit if affinity is restricted Qais Yousef
2024-02-20 22:56 ` [PATCH v6 1/4] sched/topology: Export asym_capacity_list Qais Yousef
2024-02-23 9:30 ` Vincent Guittot
2024-02-20 22:56 ` [PATCH v6 2/4] sched/fair: Check a task has a fitting cpu when updating misfit Qais Yousef
2024-02-23 9:30 ` Vincent Guittot
2024-02-23 13:48 ` [PATCH v7] " Qais Yousef
2024-02-23 13:50 ` [PATCH v6 2/4] " Qais Yousef
2024-02-27 9:42 ` Dietmar Eggemann
2024-03-03 17:44 ` Qais Yousef
2024-03-06 21:47 ` Qais Yousef
2024-03-07 9:14 ` Vincent Guittot
2024-03-07 10:35 ` Qais Yousef
2024-03-07 17:54 ` Dietmar Eggemann
2024-03-21 12:20 ` Qais Yousef
2024-02-20 22:56 ` [PATCH v6 3/4] sched/topology: Remove max_cpu_capacity from root_domain Qais Yousef
2024-02-23 9:31 ` Vincent Guittot [this message]
2024-02-20 22:56 ` [PATCH v6 4/4] sched/fair: Don't double balance_interval for migrate_misfit Qais Yousef
2024-02-23 9:32 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKfTPtAvmMFL355zrqCebZJg6Su-V_um4X-c629cOJoS09-fdQ@mail.gmail.com \
--to=vincent.guittot@linaro.org \
--cc=Pierre.Gondois@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).