From: Alexander Duyck <alexander.duyck@gmail.com>
To: Mario Limonciello <mario.limonciello@dell.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
Netdev <netdev@vger.kernel.org>, Jakub Kicinski <kuba@kernel.org>,
Sasha Netfin <sasha.neftin@intel.com>,
Aaron Brown <aaron.f.brown@intel.com>,
Stefan Assmann <sassmann@redhat.com>,
David Arcari <darcari@redhat.com>,
Yijun Shen <Yijun.Shen@dell.com>,
"Yuan, Perry" <Perry.Yuan@dell.com>,
Anthony Wong <anthony.wong@canonical.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v4 0/4] Improve s0ix flows for systems i219LM
Date: Mon, 14 Dec 2020 08:39:01 -0800 [thread overview]
Message-ID: <CAKgT0UfSeW_mod5kqNFL71Nepbk+Kg65Vw_HeLVLjykX98u=xg@mail.gmail.com> (raw)
In-Reply-To: <20201214153450.874339-1-mario.limonciello@dell.com>
On Mon, Dec 14, 2020 at 7:35 AM Mario Limonciello
<mario.limonciello@dell.com> wrote:
>
> commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
> disabled s0ix flows for systems that have various incarnations of the
> i219-LM ethernet controller. This was done because of some regressions
> caused by an earlier
> commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable connected case")
> with i219-LM controller.
>
> Per discussion with Intel architecture team this direction should be changed and
> allow S0ix flows to be used by default. This patch series includes directional
> changes for their conclusions in https://lkml.org/lkml/2020/12/13/15.
>
> Changes from v3 to v4:
> - Drop patch 1 for proper s0i3.2 entry, it was separated and is now merged in kernel
> - Add patch to only run S0ix flows if shutdown succeeded which was suggested in
> thread
> - Adjust series for guidance from https://lkml.org/lkml/2020/12/13/15
> * Revert i219-LM disallow-list.
> * Drop all patches for systems tested by Dell in an allow list
> * Increase ULP timeout to 1000ms
> Changes from v2 to v3:
> - Correct some grammar and spelling issues caught by Bjorn H.
> * s/s0ix/S0ix/ in all commit messages
> * Fix a typo in commit message
> * Fix capitalization of proper nouns
> - Add more pre-release systems that pass
> - Re-order the series to add systems only at the end of the series
> - Add Fixes tag to a patch in series.
>
> Changes from v1 to v2:
> - Directly incorporate Vitaly's dependency patch in the series
> - Split out s0ix code into it's own file
> - Adjust from DMI matching to PCI subsystem vendor ID/device matching
> - Remove module parameter and sysfs, use ethtool flag instead.
> - Export s0ix flag to ethtool private flags
> - Include more people and lists directly in this submission chain.
>
> Mario Limonciello (4):
> e1000e: Only run S0ix flows if shutdown succeeded
> e1000e: bump up timeout to wait when ME un-configure ULP mode
> Revert "e1000e: disable s0ix entry and exit flows for ME systems"
> e1000e: Export S0ix flags to ethtool
>
> drivers/net/ethernet/intel/e1000e/e1000.h | 1 +
> drivers/net/ethernet/intel/e1000e/ethtool.c | 40 ++++++++++++++
> drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 +-
> drivers/net/ethernet/intel/e1000e/netdev.c | 59 ++++-----------------
> 4 files changed, 53 insertions(+), 51 deletions(-)
>
The changes look good to me.
Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
next prev parent reply other threads:[~2020-12-14 16:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 15:34 [PATCH v4 0/4] Improve s0ix flows for systems i219LM Mario Limonciello
2020-12-14 15:34 ` [PATCH 1/4] e1000e: Only run S0ix flows if shutdown succeeded Mario Limonciello
2020-12-14 15:34 ` [PATCH 2/4] e1000e: bump up timeout to wait when ME un-configure ULP mode Mario Limonciello
2020-12-14 15:34 ` [PATCH 3/4] Revert "e1000e: disable s0ix entry and exit flows for ME systems" Mario Limonciello
2020-12-14 15:34 ` [PATCH 4/4] e1000e: Export S0ix flags to ethtool Mario Limonciello
2020-12-14 18:30 ` Hans de Goede
2020-12-14 16:39 ` Alexander Duyck [this message]
2020-12-14 18:24 ` [PATCH v4 0/4] Improve s0ix flows for systems i219LM Hans de Goede
[not found] ` <PS2PR03MB37505A15D3C9B7505D679D7BBDC70@PS2PR03MB3750.apcprd03.prod.outlook.com>
2020-12-14 18:40 ` Fw: [External] " Mark Pearson
2020-12-15 13:23 ` Neftin, Sasha
2020-12-15 17:20 ` Limonciello, Mario
2020-12-15 18:36 ` Neftin, Sasha
2020-12-14 19:36 ` Limonciello, Mario
2020-12-15 12:26 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKgT0UfSeW_mod5kqNFL71Nepbk+Kg65Vw_HeLVLjykX98u=xg@mail.gmail.com' \
--to=alexander.duyck@gmail.com \
--cc=Perry.Yuan@dell.com \
--cc=Yijun.Shen@dell.com \
--cc=aaron.f.brown@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=anthony.wong@canonical.com \
--cc=darcari@redhat.com \
--cc=davem@davemloft.net \
--cc=hdegoede@redhat.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
--cc=sasha.neftin@intel.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).