From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FFBBC433EF for ; Tue, 14 Sep 2021 15:21:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 642126113E for ; Tue, 14 Sep 2021 15:21:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234198AbhINPWs (ORCPT ); Tue, 14 Sep 2021 11:22:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233908AbhINPWr (ORCPT ); Tue, 14 Sep 2021 11:22:47 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F17F9C061574 for ; Tue, 14 Sep 2021 08:21:29 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id p29so2713123lfa.11 for ; Tue, 14 Sep 2021 08:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ssguMYfEPbOSmQk+TNSW555SqwgqRq6H3zcx/TkiIG4=; b=FOCU7M2910YmSjOs3uzHpvrnuMQJ+6M1Dun31eKpszs/tj2+qzYm9z475Xilelsvys BTeQLXu8XYRilKkeG0H+vILFGBnsfuoI4l41i+l9D7E/k6I1cRZnZDsTAspeJQBMCXxU F5g6oa+Za3j3ZMx2sgpuqVczHyUpa082sg1qrW/IjXZOJd87rVt77//45SksuqidkSUK pb8mlOl62P/Y+Y7tX0eLO93yf6UamooBU0JCZYBhcYRT2jUG4rdr6K7HLdVtlbNVQ37s bheb2rtjJcr9Nsjly6jMqj55NW9HaSIG4OFjySao28wYps/ZtTqMRil5gf+YyQmzxzcx mW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ssguMYfEPbOSmQk+TNSW555SqwgqRq6H3zcx/TkiIG4=; b=5uZ6WpwAmiHZZ8jtOKs2lcrPFNu67I1fQHD8AC19v1813NLpfQ70QUzhqutn6n1WsC fLzxunB1PBVmArq9/azsjruXaEtAInwda8CzY0DlDRLIUa5GpJDdqywUP3kxWyp5vl4+ G9aP4KxaEmui6DuPiUwV55PIy+S0QeNMrpnCvcTNzISw68GrjSGlYb52lWC/T0QUxNOV iy4+aJ025Oyj3a50KWAOlbBZT5iv52VUoyQ/VdBXd9FaIB3autGvw38ALdbxznHgBWKa nffp8MZ+9QRtgY2YS0ImaJ29Vk3ufggLp+iRr+qA+Su8EtV/0pb3xAQUiTt2dQV8KSOF V3lA== X-Gm-Message-State: AOAM532wz8tKHaYSP3Moe0NWyXtNLuSGlK5q1y5TLMBL7jpk+Bncfs2y w1RbR4QtZu9udIJzs/zQhX+vg4toSDX9JzhvGGKUxg== X-Google-Smtp-Source: ABdhPJzOgrp5/KaLNcSbRF5B6CJF4GNxa2fJrA0U7BpG9Ipq4En12c5XU9s2SEiPI6eY+owf3+qaJ4UpNavZz4Ja6Kk= X-Received: by 2002:a05:6512:1114:: with SMTP id l20mr14101535lfg.550.1631632888098; Tue, 14 Sep 2021 08:21:28 -0700 (PDT) MIME-Version: 1.0 References: <20210910234047.1019925-1-ndesaulniers@google.com> <20210910234047.1019925-11-ndesaulniers@google.com> <9433c702-ecf2-4197-2456-59857d38538d@kernel.org> In-Reply-To: <9433c702-ecf2-4197-2456-59857d38538d@kernel.org> From: Nick Desaulniers Date: Tue, 14 Sep 2021 08:21:16 -0700 Message-ID: Subject: Re: [PATCH 10/10] vmlinux.lds.h: remove old check for GCC 4.9 To: Nathan Chancellor Cc: Andrew Morton , Linus Torvalds , Rasmus Villemoes , Masahiro Yamada , Joe Perches , Arnd Bergmann , Stephen Rothwell , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2021 at 4:51 PM Nathan Chancellor wrote: > > On 9/10/2021 4:40 PM, Nick Desaulniers wrote: > > Now that GCC 5.1 is the minimally supported version of GCC, we can > > effectively revert > > > > commit 85c2ce9104eb ("sched, vmlinux.lds: Increase STRUCT_ALIGNMENT to > > 64 bytes for GCC-4.9") > > > > Cc: Peter Zijlstra > > Signed-off-by: Nick Desaulniers > > --- > > include/asm-generic/vmlinux.lds.h | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > > index aa50bf2959fe..f2984af2b85b 100644 > > --- a/include/asm-generic/vmlinux.lds.h > > +++ b/include/asm-generic/vmlinux.lds.h > > @@ -116,11 +116,7 @@ > > * GCC 4.5 and later have a 32 bytes section alignment for structures. > > * Except GCC 4.9, that feels the need to align on 64 bytes. > > Comment should be adjusted. I thought it was still interesting. Perhaps one day it will be super irrelevant. -- Thanks, ~Nick Desaulniers