From: Nick Desaulniers <ndesaulniers@google.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, Qian Cai <cai@lca.pw>,
Mark Brown <broonie@kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Vasily Gorbik <gor@linux.ibm.com>,
LKML <linux-kernel@vger.kernel.org>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH] [v2] kasan: remove clang version check for KASAN_STACK
Date: Fri, 19 Jul 2019 13:56:27 -0700 [thread overview]
Message-ID: <CAKwvOdkv9DebPrB1BLriY+SY5a8EX5VsDVLRS-2-cbORMdTcTQ@mail.gmail.com> (raw)
In-Reply-To: <20190719200347.2596375-1-arnd@arndb.de>
On Fri, Jul 19, 2019 at 1:03 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> asan-stack mode still uses dangerously large kernel stacks of
> tens of kilobytes in some drivers, and it does not seem that anyone
> is working on the clang bug.
Acked-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Turn it off for all clang versions to prevent users from
> accidentally enabling it once they update to clang-9, and
> to help automated build testing with clang-9.
>
> Link: https://bugs.llvm.org/show_bug.cgi?id=38809
> Fixes: 6baec880d7a5 ("kasan: turn off asan-stack for clang-8 and earlier")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: disable the feature for all clang versions, not just 9 and below.
> ---
> lib/Kconfig.kasan | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan
> index 4fafba1a923b..7fa97a8b5717 100644
> --- a/lib/Kconfig.kasan
> +++ b/lib/Kconfig.kasan
> @@ -106,7 +106,6 @@ endchoice
>
> config KASAN_STACK_ENABLE
> bool "Enable stack instrumentation (unsafe)" if CC_IS_CLANG && !COMPILE_TEST
> - default !(CLANG_VERSION < 90000)
> depends on KASAN
> help
> The LLVM stack address sanitizer has a know problem that
> @@ -115,11 +114,11 @@ config KASAN_STACK_ENABLE
> Disabling asan-stack makes it safe to run kernels build
> with clang-8 with KASAN enabled, though it loses some of
> the functionality.
> - This feature is always disabled when compile-testing with clang-8
> - or earlier to avoid cluttering the output in stack overflow
> - warnings, but clang-8 users can still enable it for builds without
> - CONFIG_COMPILE_TEST. On gcc and later clang versions it is
> - assumed to always be safe to use and enabled by default.
> + This feature is always disabled when compile-testing with clang
> + to avoid cluttering the output in stack overflow warnings,
> + but clang users can still enable it for builds without
> + CONFIG_COMPILE_TEST. On gcc it is assumed to always be safe
> + to use and enabled by default.
>
> config KASAN_STACK
> int
> --
> 2.20.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20190719200347.2596375-1-arnd%40arndb.de.
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2019-07-19 20:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:03 [PATCH] [v2] kasan: remove clang version check for KASAN_STACK Arnd Bergmann
2019-07-19 20:56 ` Nick Desaulniers [this message]
2019-07-22 12:27 ` Andrey Ryabinin
2019-07-22 12:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdkv9DebPrB1BLriY+SY5a8EX5VsDVLRS-2-cbORMdTcTQ@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=broonie@kernel.org \
--cc=cai@lca.pw \
--cc=clang-built-linux@googlegroups.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gor@linux.ibm.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).