From: Nick Desaulniers <ndesaulniers@google.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Miroslav Benes <mbenes@suse.cz>, Borislav Petkov <bp@suse.de>,
Julien Thierry <jthierry@redhat.com>
Subject: Re: [PATCH] objtool: Don't fail the kernel build on fatal errors
Date: Fri, 15 Jan 2021 10:45:01 -0800 [thread overview]
Message-ID: <CAKwvOdm47R1UxPGfHa_2FCUJwwACqMYFoPNuyaab_N6qW-OWow@mail.gmail.com> (raw)
In-Reply-To: <9ec7a9531e99f461e02adc18a4124c921c0ab777.1610664286.git.jpoimboe@redhat.com>
On Thu, Jan 14, 2021 at 2:46 PM Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> This is basically a revert of commit 644592d32837 ("objtool: Fail the
> kernel build on fatal errors").
>
> That change turned out to be more trouble than it's worth. Failing the
> build is an extreme measure which sometimes gets too much attention and
> blocks CI build testing.
>
> These fatal-type warnings aren't yet as rare as we'd hope, due to the
> ever-increasing matrix of supported toolchains/plugins and their
> fast-changing nature as of late.
>
> Also, there are more people (and bots) looking for objtool warnings than
> ever before, so such warnings not likely to be ignored for long.
>
> Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Thank you; I feel the arguments against enabling -Werror for the
kernel apply here. The warnings are annoying enough that we plan to
follow up on them all.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
> ---
> tools/objtool/check.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 5f8d3eed78a1..4bd30315eb62 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -2928,14 +2928,10 @@ int check(struct objtool_file *file)
> warnings += ret;
>
> out:
> - if (ret < 0) {
> - /*
> - * Fatal error. The binary is corrupt or otherwise broken in
> - * some way, or objtool itself is broken. Fail the kernel
> - * build.
> - */
> - return ret;
> - }
> -
> + /*
> + * For now, don't fail the kernel build on fatal warnings. These
> + * errors are still fairly common due to the growing matrix of
> + * supported toolchains and their recent pace of change.
> + */
> return 0;
> }
> --
> 2.29.2
>
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2021-01-15 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 22:45 [PATCH] objtool: Don't fail the kernel build on fatal errors Josh Poimboeuf
2021-01-15 11:39 ` Miroslav Benes
2021-01-15 18:45 ` Nick Desaulniers [this message]
2021-01-21 4:52 ` Kamalesh Babulal
2021-01-21 7:32 ` György Andrasek
2021-01-22 2:27 ` Steven Rostedt
2021-01-22 7:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwvOdm47R1UxPGfHa_2FCUJwwACqMYFoPNuyaab_N6qW-OWow@mail.gmail.com \
--to=ndesaulniers@google.com \
--cc=bp@suse.de \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).