From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC56C433E2 for ; Tue, 21 Jul 2020 12:56:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3B272073A for ; Tue, 21 Jul 2020 12:56:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GcQgWDbM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727866AbgGUM4e (ORCPT ); Tue, 21 Jul 2020 08:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726749AbgGUM4d (ORCPT ); Tue, 21 Jul 2020 08:56:33 -0400 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46059C061794; Tue, 21 Jul 2020 05:56:33 -0700 (PDT) Received: by mail-io1-xd41.google.com with SMTP id v6so21240904iob.4; Tue, 21 Jul 2020 05:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=O6bopuOOfAu1QyL2Kms3hUZ2O5zKxrgd6kI2Tv7qUhc=; b=GcQgWDbM6MyNtrEXX/ohqqTCM+9gbcIToFUroFBDPwAbR/cZqLSjUC4IJBpwNy/tde 0BJF4i8T1nZEyz4hTI8J5bV2nOJ/d54bUytKUkUcvXq1jL6Aen/JUP6QLTx73syWU8ug xKuFZaU15DV/RUeghKIa7aO9hAV278US/xBe+MF0Ywoyn/Lzxr6yj2mBIs9qrfVmKDTm wbgGmJNXjsJ0+fHREHb8ZVXTodgUTZb3kTmrUbR5yehQszJ1stB+c6y8lBrkrqFQS3SS LVrPwEhb0F5ppdF8A+oQ5qRyYVNATKk1qyOBMAKrp5ofjF/XbIR3YuRnCl8iZBmq8iiY 91cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=O6bopuOOfAu1QyL2Kms3hUZ2O5zKxrgd6kI2Tv7qUhc=; b=F8jWfwRAuHII/oyQY9qaBr/iGqbqVBzoznjXrnfJoY1B8XnJTBXELqH0hpYlGDpbDc l57Cc3WKWnJFiwne67epy9K5j8wsuB1uAGQ0geBGgDIGChL5G7fxfUs1e100u3594N+4 ZEUsmmDbPJ1p1rnXNoAfeTHxGFHVSXDASniu1AYKus64/El7qpTpSWYsmCiz8eL+ePE3 DZx7Mh5IhyAaYCrYKE62/fGRB/5iuNUV1F6vnWNz6xcUopLa1uiVYx3XIP5PJzsDafQM URqnRwaodPTmGqyxRIY5+sta8Gg/QWgwd8jWkonZUF4Py3wX+mw10/Dil/+8DF2L5Z9a Adag== X-Gm-Message-State: AOAM532fjFt10QWqQxCU30q9ioMwvHJGG3eCgUWxqa49OOMxGgTZ2Zm9 2Y0lwnlA3QVG97ktf7393aT5fEYlmPb4kbW26OM= X-Google-Smtp-Source: ABdhPJznWC3OQjMqlA5mkExmNk1wQAUH1ezUc/cEd6b70d11rwBl9XImmQTNINXeh7VQ2VjnKFPxDAX8V8eYpVp0QO8= X-Received: by 2002:a02:9109:: with SMTP id a9mr32686269jag.130.1595336192539; Tue, 21 Jul 2020 05:56:32 -0700 (PDT) MIME-Version: 1.0 References: <1590378062-7965-1-git-send-email-dillon.minfei@gmail.com> <198ad79c-ab12-55f0-814f-afc454a7e8ef@st.com> In-Reply-To: From: dillon min Date: Tue, 21 Jul 2020 20:55:55 +0800 Message-ID: Subject: Re: [PATCH v5 0/8] Enable ili9341 and l3gd20 on stm32f429-disco To: Alexandre Torgue Cc: Rob Herring , p.zabel@pengutronix.de, Maxime Coquelin , thierry.reding@gmail.com, Sam Ravnborg , Dave Airlie , Daniel Vetter , Michael Turquette , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux Kernel Mailing List , linux-spi , linux-stm32@st-md-mailman.stormreply.com, "open list:DRM PANEL DRIVERS" , linux-clk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Alexandre, On Tue, Jul 21, 2020 at 7:54 PM Alexandre Torgue wrote: > > > > On 7/21/20 12:39 PM, dillon min wrote: > > Hi Alexandre, > > > > On Tue, Jul 21, 2020 at 5:19 PM Alexandre Torgue > > wrote: > >> > >> Hi Dillon > >> > >> On 5/25/20 5:40 AM, dillon.minfei@gmail.com wrote: > >>> From: dillon min > >>> > >>> V5's update based on Mark Brown's suggestion, use 'SPI_MASTER_MUST_RX= ' > >>> for SPI_SIMPLEX_RX mode on stm32 spi controller. > >>> > >>> V5: > >>> 1 instead of add send dummy data out under SIMPLEX_RX mode, > >>> add flags 'SPI_CONTROLLER_MUST_TX' for stm32 spi driver > >>> 2 bypass 'SPI_CONTROLLER_MUST_TX' and 'SPI_CONTROLLER_MUST_RX' under > >>> 'SPI_3WIRE' mode > >>> > >> > >> Concerning DT patches, they look goods for me. However I'll merge them > >> when drivers parts will be merged. > >> > >> regards > >> Alex > > This patchset status is : > > dts: > > ARM: dts: stm32: Add dma config for spi5 > > ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco bo= ard > > ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on > > stm32429-disco board > > > > panel-bindings: Reviewed-by: Rob Herring=EF=BC=8C need more reviewing t= o merge > > dt-bindings: display: panel: Add ilitek ili9341 panel bindings > > > > clk: Acked-by: Stephen Boyd , need more reviewing to merge > > clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate, > > fix duplicated ltdc clock register to 'clk_core' case ltdc's clo= ck > > turn off by clk_disable_unused() > > > > drm-panel: Reviewed-by: Linus Walleij . need more reviewing to merge > > drm/panel: Add ilitek ili9341 panel driver > > > > spi-driver: Acked-by: Mark Brown =EF=BC=8Cmerged into mainline > > spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32= f4 > > spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' c= an't > > becoexit with 'SPI_3WIRE' mode > > > > For ili9341 drivers, it seems to need more time to review, or might be = dropped. > > since the drm maintainer might create a new interface to support > > DPI,DBI,DSI in one driver. > > Currently it's under discussion. I will rework the ili9341 driver after= that. > > > > But, we can use the existing "drivers/gpu/drm/tiny/ili9341.c" driver to= support > > ili9341 on stm32f429-disco board only using the spi bus. except the > > display refresh performance is not as good as the ltdc interface. > > > > I can submit a new patch just with dts changed this week for it, if you= need. > > > > > Thanks for this status. I'm close to send my PR for v5.9. There is no > needs to have an intermediate version (Except you absolutely want it). > > Thanks > alex Ok, I prefer to use the ltdc interface to drive ili9341 either. Thanks, Dillon. > > > Thanks, > > Dillon. > >> > >> > >> > >>> V4: > >>> According to alexandre torgue's suggestion, combine ili9341 and > >>> l3gd20's modification on stm32f429-disco board to one patchset. > >>> > >>> Changes: > >>> > >>> ili9341: > >>> > >>> 1 update ili9341 panel driver according to Linus's suggestion > >>> 2 drop V1's No.5 patch, sumbit new changes for clk-stm32f4 > >>> 3 merge l3gd20's change to this patchset > >>> > >>> V3: > >>> 1 merge original tiny/ili9341.c driver to panel/panel-ilitek-ili9341.= c > >>> to support serial spi & parallel rgb interface in one driver. > >>> 2 update ilitek,ili9341.yaml dts binding documentation. > >>> 3 update stm32f429-disco dts binding > >>> > >>> V2: > >>> 1 verify ilitek,ili9341.yaml with make O=3D../linux-stm32 > >>> dt_binding_check > >>> DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/display/panel= / > >>> ilitek,ili9341.yaml > >>> > >>> V1: > >>> 1 add ili9341 drm panel driver > >>> 2 add ltdc, spi5 controller for stm32f429-disco > >>> 3 add ltdc, spi5 pin map for stm32f429-disco > >>> 4 add docs about ili9341 > >>> 5 fix ltdc driver loading hang in clk set rate bug > >>> > >>> > >>> L3gd20: > >>> V3: > >>> 1 merge stm32f429-disco dtbs binding with ili9341 part > >>> > >>> V2: > >>> 1 insert blank line at stm32f420-disco.dts line 143 > >>> 2 add more description for l3gd20 in commit message > >>> > >>> V1: > >>> 1 enable spi5 controller on stm32f429-disco (dts) > >>> 2 add spi5 pinmap for stm32f429-disco (dts) > >>> 3 add SPI_SIMPLEX_RX, SPI_3WIRE_RX support for stm32f4 > >>> > >>> > >>> dillon min (8): > >>> ARM: dts: stm32: Add dma config for spi5 > >>> ARM: dts: stm32: Add pin map for ltdc & spi5 on stm32f429-disco b= oard > >>> ARM: dts: stm32: enable ltdc binding with ili9341, gyro l3gd20 on > >>> stm32429-disco board > >>> dt-bindings: display: panel: Add ilitek ili9341 panel bindings > >>> clk: stm32: Fix stm32f429's ltdc driver hang in set clock rate, > >>> fix duplicated ltdc clock register to 'clk_core' case ltdc's cl= ock > >>> turn off by clk_disable_unused() > >>> drm/panel: Add ilitek ili9341 panel driver > >>> spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm3= 2f4 > >>> spi: flags 'SPI_CONTROLLER_MUST_RX' and 'SPI_CONTROLLER_MUST_TX' = can't > >>> be coexit with 'SPI_3WIRE' mode > >>> > >>> .../bindings/display/panel/ilitek,ili9341.yaml | 69 ++ > >>> arch/arm/boot/dts/stm32f4-pinctrl.dtsi | 67 + > >>> arch/arm/boot/dts/stm32f429-disco.dts | 48 + > >>> arch/arm/boot/dts/stm32f429.dtsi | 3 + > >>> drivers/clk/clk-stm32f4.c | 7 +- > >>> drivers/gpu/drm/panel/Kconfig | 12 + > >>> drivers/gpu/drm/panel/Makefile | 1 + > >>> drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 1301 ++++++++= ++++++++++++ > >>> drivers/spi/spi-stm32.c | 19 +- > >>> drivers/spi/spi.c | 3 +- > >>> 10 files changed, 1521 insertions(+), 9 deletions(-) > >>> create mode 100644 Documentation/devicetree/bindings/display/panel= /ilitek,ili9341.yaml > >>> create mode 100644 drivers/gpu/drm/panel/panel-ilitek-ili9341.c > >>>