From: Bobby Jones <rjones@gateworks.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH v3 1/4] ARM: dts: imx: Add GW5907 board support
Date: Mon, 23 Dec 2019 14:55:19 -0800 [thread overview]
Message-ID: <CALAE=UAok8dazxPj16TAV7rQ_6EZvLBp3t5J2CjweMyECkZAHA@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5CLfyZjuz3c+Xr9v0D5h+r83PGgi8BrMnQZOOZSM-iGGw@mail.gmail.com>
On Mon, Dec 23, 2019 at 2:06 PM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Robert,
>
> On Mon, Dec 23, 2019 at 6:44 PM Robert Jones <rjones@gateworks.com> wrote:
> >
> > The Gateworks GW5907 is an IMX6 SoC based single board computer with:
> > - IMX6Q or IMX6DL
> > - 32bit DDR3 DRAM
> > - FEC GbE Phy
> > - bi-color front-panel LED
> > - 256MB NAND boot device
> > - Gateworks System Controller (hwmon, pushbutton controller, EEPROM)
> > - Digital IO expander (pca9555)
> > - Joystick 12bit adc (ads1015)
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > Signed-off-by: Robert Jones <rjones@gateworks.com>
>
> Not clear on the authorship on this patch.
>
> If the original author is Tim, then his name should appear in the From field.
>
Original author for all but the GW5910 patch was myself. It's probably
not clear here but Tim reviewed the patches prior to submission and
had me add him as a Signed-off-by.
Would it be better to just remove those lines from the patches in this case?
> > ---
> > arch/arm/boot/dts/Makefile | 2 +
> > arch/arm/boot/dts/imx6dl-gw5907.dts | 14 ++
> > arch/arm/boot/dts/imx6q-gw5907.dts | 14 ++
> > arch/arm/boot/dts/imx6qdl-gw5907.dtsi | 399 ++++++++++++++++++++++++++++++++++
> > 4 files changed, 429 insertions(+)
> > create mode 100644 arch/arm/boot/dts/imx6dl-gw5907.dts
> > create mode 100644 arch/arm/boot/dts/imx6q-gw5907.dts
> > create mode 100644 arch/arm/boot/dts/imx6qdl-gw5907.dtsi
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 1e9e1af..9ee80e2 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -422,6 +422,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > imx6dl-gw560x.dtb \
> > imx6dl-gw5903.dtb \
> > imx6dl-gw5904.dtb \
> > + imx6dl-gw5907.dtb \
>
> You should add an additional patch that add these new boards in
> Documentation/devicetree/bindings/arm/fsl.yaml
So I was planning on just adding an enum line for "gw,ventana" under
the i.MX6DL and i.MX6Q based Boards sections. Would that be
sufficient?
We have a lot of individual custom boards and it doesn't seem correct
to add individual strings for every one in both sections.
next prev parent reply other threads:[~2019-12-23 22:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 21:44 [PATCH v3 0/4] ARM: dts: imx: Add GW59xx Gateworks specials Robert Jones
2019-12-23 21:44 ` [PATCH v3 1/4] ARM: dts: imx: Add GW5907 board support Robert Jones
2019-12-23 22:05 ` Fabio Estevam
2019-12-23 22:55 ` Bobby Jones [this message]
2019-12-24 1:50 ` Fabio Estevam
2019-12-23 21:44 ` [PATCH v3 2/4] ARM: dts: imx: Add GW5910 " Robert Jones
2019-12-23 22:07 ` Fabio Estevam
2019-12-23 21:44 ` [PATCH v3 3/4] ARM: dts: imx: Add GW5913 " Robert Jones
2019-12-23 21:44 ` [PATCH v3 4/4] ARM: dts: imx: Add GW5912 " Robert Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAE=UAok8dazxPj16TAV7rQ_6EZvLBp3t5J2CjweMyECkZAHA@mail.gmail.com' \
--to=rjones@gateworks.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).