linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Youlin Wang <wwx575822@notesmail.huawei.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Zhuangluan Su <suzhuangluan@hisilicon.com>,
	Ryan Grachek <ryan@edited.us>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	"open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" 
	<dmaengine@vger.kernel.org>, Tanglei Han <hantanglei@huawei.com>
Subject: Re: [PATCH 3/8 v4] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware
Date: Wed, 23 Jan 2019 20:32:31 -0800	[thread overview]
Message-ID: <CALAqxLVAvLN29M4b+NRzhWbbUjAsSk_h1y58bPviz5SWqcY1NQ@mail.gmail.com> (raw)
In-Reply-To: <20190123125533.GP4635@vkoul-mobl>

On Wed, Jan 23, 2019 at 4:57 AM Vinod Koul <vkoul@kernel.org> wrote:
> On 22-01-19, 15:48, John Stultz wrote:
> > Do let me know if there's an example you'd rather I follow.
>
> To elaborate I was thinking of alternate scheme with:
>
>         compatible = "hisilicon,k3-dma-1.0", NULL
>         compatible = "hisilicon,hisi-pcm-asp-dma-1.0", .data = &asp_v1_dma_data
>
> and
>
>         soc_data = device_get_match_data(&op->dev);
>         if (!soc_data) {
>                 /* no data so flags are null */
>                 dev_warn(... "no driver data specified, assuming  no flags\n"
>                 k3_dma->flags = 0;
>         }

Thanks for the clarification! Hmm. I can do this, though the trouble
is all the soc_data-> references have to switch to a struct
k3dma_soc_data on the stack, which we have to initialize/copy over
depending on the soc_data return, which I'm not sure really simplifies
much (other then saving a ulong off the heap). But I'm ok with either.

thanks
-john

  reply	other threads:[~2019-01-24  4:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 17:10 [PATCH 0/8 v4] k3dma patches to add support for hi3660/HiKey960 John Stultz
2019-01-16 17:10 ` [PATCH 1/8 v4] Documentation: bindings: k3dma: Extend the k3dma driver binding to support hisi-asp John Stultz
2019-01-16 17:10 ` [PATCH 2/8 v4] Documentation: bindings: dma: Add binding for dma-channel-mask John Stultz
2019-01-17 17:08   ` Manivannan Sadhasivam
2019-01-17 17:43     ` John Stultz
2019-01-20 11:06       ` Vinod Koul
2019-01-22  1:13   ` Rob Herring
2019-01-16 17:10 ` [PATCH 3/8 v4] dma: k3dma: Upgrade k3dma driver to support hisi_asp_dma hardware John Stultz
2019-01-20 11:11   ` Vinod Koul
2019-01-22 23:48     ` John Stultz
2019-01-23 12:55       ` Vinod Koul
2019-01-24  4:32         ` John Stultz [this message]
2019-01-16 17:10 ` [PATCH 4/8 v4] dma: k3dma: Delete axi_config John Stultz
2019-01-16 17:10 ` [PATCH 5/8 v4] dma: k3dma: Add support for dma-channel-mask John Stultz
2019-01-17 17:14   ` Manivannan Sadhasivam
2019-01-23  0:27     ` John Stultz
2019-01-16 17:10 ` [PATCH 6/8 v4] arm64: dts: hi3660: Add dma to uart nodes John Stultz
2019-01-16 17:10 ` [PATCH 7/8 v4] arm64: dts: hi3660: Add hisi asp dma device John Stultz
2019-01-16 17:10 ` [PATCH 8/8 v4] arm64: dts: hi3660: Fixup unofficial dma-min-chan to dma-channel-mask John Stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALAqxLVAvLN29M4b+NRzhWbbUjAsSk_h1y58bPviz5SWqcY1NQ@mail.gmail.com \
    --to=john.stultz@linaro.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=hantanglei@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=ryan@edited.us \
    --cc=suzhuangluan@hisilicon.com \
    --cc=vkoul@kernel.org \
    --cc=wwx575822@notesmail.huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).