From: John Stultz <john.stultz@linaro.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Sandeep Patil <sspatil@google.com>,
Laura Abbott <labbott@redhat.com>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
Liam Mark <lmark@codeaurora.org>,
Pratik Patel <pratikp@codeaurora.org>,
Brian Starkey <Brian.Starkey@arm.com>,
"Andrew F . Davis" <afd@ti.com>,
Andrew Morton <akpm@linux-foundation.org>,
Yue Hu <huyue2@yulong.com>, Mike Rapoport <rppt@linux.ibm.com>,
Chenbo Feng <fengc@google.com>,
Alistair Strachan <astrachan@google.com>,
Hridya Valsaraju <hridya@google.com>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module
Date: Mon, 28 Oct 2019 15:23:57 -0700 [thread overview]
Message-ID: <CALAqxLVW8KQVKwu=AY5Hkv7m9_L6djDy8h0se46MA+t_9_CCgg@mail.gmail.com> (raw)
In-Reply-To: <CALAqxLXqLUpew9XptiXZGodf5M3qyNmD-D1-2CHZ9PRfPTBRRQ@mail.gmail.com>
On Mon, Oct 28, 2019 at 11:39 AM John Stultz <john.stultz@linaro.org> wrote:
> On Mon, Oct 28, 2019 at 12:46 AM Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Fri, Oct 25, 2019 at 11:48:33PM +0000, John Stultz wrote:
> > > struct cma *dma_contiguous_default_area;
> > > +EXPORT_SYMBOL(dma_contiguous_default_area);
> >
> > Please CC the dma maintainer. And no, you have no business using this.
>
> Sure thing. And I'll look again to see why I was needing to pull that
> one in to get it to build.
Ah. So looking a bit closer, I'm needing this due to my using
dev_get_cma_area() to get the default cma area for the dmabuf
cma_heap.
Do you have a suggestion for how to get a reference to the default CMA
area without exporting dma_contiguous_default_area? Would it be
preferred to move dev_get_cma_area() into the .c file and
EXPORT_SYMBOL_GPL that function?
thanks
-john
next prev parent reply other threads:[~2019-10-28 22:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 23:48 [RFC][PATCH 0/2] Allow DMA BUF heaps to be loaded as modules John Stultz
2019-10-25 23:48 ` [RFC][PATCH 1/2] mm: cma: Export cma symbols for cma heap as a module John Stultz
2019-10-28 7:46 ` Christoph Hellwig
2019-10-28 18:39 ` John Stultz
2019-10-28 22:23 ` John Stultz [this message]
2019-10-28 19:12 ` sspatil
2019-10-28 20:03 ` John Stultz
2019-10-28 22:26 ` John Stultz
2019-10-25 23:48 ` [RFC][PATCH 2/2] dma-buf: heaps: Allow system & cma heaps to be configured as a modules John Stultz
2019-11-04 9:45 ` Brian Starkey
2019-11-04 10:24 ` Daniel Vetter
2019-11-04 19:00 ` John Stultz
2019-11-04 9:58 ` [RFC][PATCH 0/2] Allow DMA BUF heaps to be loaded as modules Daniel Vetter
2019-11-04 18:57 ` John Stultz
2019-11-05 9:42 ` Daniel Vetter
2019-11-05 13:30 ` Andrew F. Davis
2019-11-05 13:58 ` Daniel Vetter
2019-11-05 17:41 ` John Stultz
2019-11-05 19:18 ` Daniel Vetter
2019-11-05 19:47 ` John Stultz
2019-11-05 20:21 ` Daniel Vetter
2019-11-12 0:56 ` Sandeep Patil
2019-11-12 0:49 ` Sandeep Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALAqxLVW8KQVKwu=AY5Hkv7m9_L6djDy8h0se46MA+t_9_CCgg@mail.gmail.com' \
--to=john.stultz@linaro.org \
--cc=Brian.Starkey@arm.com \
--cc=afd@ti.com \
--cc=akpm@linux-foundation.org \
--cc=astrachan@google.com \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=fengc@google.com \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=huyue2@yulong.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmark@codeaurora.org \
--cc=pratikp@codeaurora.org \
--cc=rppt@linux.ibm.com \
--cc=sspatil@google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).