From: Dan Streetman <ddstreet@ieee.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-next@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the modules tree
Date: Wed, 24 Jun 2015 14:18:44 -0400 [thread overview]
Message-ID: <CALZtONAqdXeV0=Enjsw6YzuWFC-4ZqpeWfwxcEgBa+1CasqbGA@mail.gmail.com> (raw)
In-Reply-To: <20150624113727.4f61ba18@canb.auug.org.au>
On Tue, Jun 23, 2015 at 9:37 PM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Rusty,
>
> After merging the modules tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
that's weird. Are you sure it failed during allmodconfig? I can see
why it would fail like that if CONFIG_MODULES ins't defined, which
I'll send a patch for...
>
> In file included from include/linux/linkage.h:4:0,
> from include/linux/kernel.h:6,
> from kernel/params.c:18:
> kernel/params.c: In function 'param_array':
> kernel/params.c:32:42: error: dereferencing pointer to incomplete type
> #define KPARAM_MUTEX(mod) ((mod) ? &(mod)->param_lock : ¶m_lock)
> ^
> include/linux/compiler.h:164:42: note: in definition of macro 'unlikely'
> # define unlikely(x) __builtin_expect(!!(x), 0)
> ^
> kernel/params.c:462:3: note: in expansion of macro 'BUG_ON'
> BUG_ON(!KPARAM_IS_LOCKED(mod));
> ^
> kernel/params.c:33:47: note: in expansion of macro 'KPARAM_MUTEX'
> #define KPARAM_IS_LOCKED(mod) mutex_is_locked(KPARAM_MUTEX(mod))
> ^
> kernel/params.c:462:11: note: in expansion of macro 'KPARAM_IS_LOCKED'
> BUG_ON(!KPARAM_IS_LOCKED(mod));
> ^
> kernel/params.c: In function 'param_array_get':
> kernel/params.c:32:42: error: dereferencing pointer to incomplete type
> #define KPARAM_MUTEX(mod) ((mod) ? &(mod)->param_lock : ¶m_lock)
> ^
> include/linux/compiler.h:164:42: note: in definition of macro 'unlikely'
> # define unlikely(x) __builtin_expect(!!(x), 0)
> ^
> kernel/params.c:499:3: note: in expansion of macro 'BUG_ON'
> BUG_ON(!KPARAM_IS_LOCKED(p.mod));
> ^
> kernel/params.c:33:47: note: in expansion of macro 'KPARAM_MUTEX'
> #define KPARAM_IS_LOCKED(mod) mutex_is_locked(KPARAM_MUTEX(mod))
> ^
> kernel/params.c:499:11: note: in expansion of macro 'KPARAM_IS_LOCKED'
> BUG_ON(!KPARAM_IS_LOCKED(p.mod));
> ^
> In file included from include/linux/notifier.h:13:0,
> from include/linux/memory_hotplug.h:6,
> from include/linux/mmzone.h:789,
> from include/linux/gfp.h:5,
> from include/linux/kmod.h:22,
> from include/linux/module.h:13,
> from kernel/params.c:21:
> kernel/params.c: In function 'kernel_param_lock':
> kernel/params.c:32:42: error: dereferencing pointer to incomplete type
> #define KPARAM_MUTEX(mod) ((mod) ? &(mod)->param_lock : ¶m_lock)
> ^
> include/linux/mutex.h:146:44: note: in definition of macro 'mutex_lock'
> #define mutex_lock(lock) mutex_lock_nested(lock, 0)
> ^
> kernel/params.c:621:13: note: in expansion of macro 'KPARAM_MUTEX'
> mutex_lock(KPARAM_MUTEX(mod));
> ^
> kernel/params.c: In function 'kernel_param_unlock':
> kernel/params.c:32:42: error: dereferencing pointer to incomplete type
> #define KPARAM_MUTEX(mod) ((mod) ? &(mod)->param_lock : ¶m_lock)
> ^
> kernel/params.c:626:15: note: in expansion of macro 'KPARAM_MUTEX'
> mutex_unlock(KPARAM_MUTEX(mod));
> ^
>
> Caused by commit b51d23e4e9fe ("module: add per-module param_lock").
>
> I am not exactly sure why this fails to build. It may be an
> interaction with some other change.
>
> I have used the modules tree from next-20150623 for today.
>
> --
> Cheers,
> Stephen Rothwell sfr@canb.auug.org.au
next prev parent reply other threads:[~2015-06-24 18:19 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 1:37 linux-next: build failure after merge of the modules tree Stephen Rothwell
2015-06-24 18:18 ` Dan Streetman [this message]
2015-06-24 18:31 ` [PATCH] modules: only use mod->param_lock if CONFIG_MODULES Dan Streetman
2015-06-24 22:57 ` linux-next: build failure after merge of the modules tree Stephen Rothwell
2015-06-25 1:50 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2024-02-02 1:03 Stephen Rothwell
2022-11-14 0:13 Stephen Rothwell
2022-11-14 8:01 ` Jiri Olsa
2022-11-14 9:08 ` Leizhen (ThunderTown)
2022-02-21 16:07 broonie
2022-02-23 0:32 ` Luis Chamberlain
2022-02-28 5:13 ` Stephen Rothwell
2022-02-28 18:16 ` Luis Chamberlain
2021-02-09 10:08 Stephen Rothwell
2021-02-09 15:16 ` Jessica Yu
2021-02-09 16:06 ` Christoph Hellwig
2021-02-09 21:50 ` Stephen Rothwell
2021-02-10 8:06 ` Jessica Yu
2021-02-10 8:37 ` Masahiro Yamada
2021-02-11 6:19 ` Masahiro Yamada
2021-02-10 12:21 ` Stephen Rothwell
2021-02-10 16:16 ` Jessica Yu
2019-06-25 4:27 Stephen Rothwell
2015-12-01 20:23 Mark Brown
2015-12-02 3:23 ` Rusty Russell
2015-11-27 1:26 Stephen Rothwell
2015-11-27 2:57 ` Rusty Russell
2015-06-25 6:54 Stephen Rothwell
2015-06-25 9:51 ` Dan Streetman
2014-12-18 2:05 Stephen Rothwell
2014-08-07 3:20 Stephen Rothwell
2014-08-07 11:37 ` Rusty Russell
2014-08-07 13:03 ` Stephen Rothwell
2014-08-07 13:07 ` Rusty Russell
2014-08-08 1:33 ` Stephen Rothwell
2014-07-28 3:58 Stephen Rothwell
2014-07-28 11:38 ` Rusty Russell
2014-03-25 3:02 Stephen Rothwell
2014-03-31 3:45 ` Rusty Russell
2012-11-26 4:10 Stephen Rothwell
2012-11-28 11:02 ` Stanislaw Gruszka
2012-12-03 0:29 ` Rusty Russell
2012-11-02 1:57 Stephen Rothwell
2012-11-02 3:16 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALZtONAqdXeV0=Enjsw6YzuWFC-4ZqpeWfwxcEgBa+1CasqbGA@mail.gmail.com' \
--to=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).