From: Rob Herring <robh@kernel.org>
To: Nicolas Ferre <Nicolas.Ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Ludovic Desroches <Ludovic.Desroches@microchip.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Sebastian Reichel <sre@kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Linux USB List <linux-usb@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface
Date: Tue, 22 Jan 2019 07:41:02 -0600 [thread overview]
Message-ID: <CAL_Jsq+31C2KXNy_GeVU9g7mZ_aSw3yqdjU-V5mV2Xdc200TuA@mail.gmail.com> (raw)
In-Reply-To: <be8ba0bf-993e-d38c-61e8-af422ff3c636@microchip.com>
On Tue, Jan 22, 2019 at 3:09 AM <Nicolas.Ferre@microchip.com> wrote:
>
> Hi Rob,
>
> On 22/01/2019 at 02:10, Rob Herring wrote:
> > On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote:
> >> This removes a line left while adding the correct compatibility string for
> >> sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string.
> >>
> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >> ---
> >> Documentation/devicetree/bindings/net/macb.txt | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
> >> index 3e17ac1d5d58..f5c414b10e27 100644
> >> --- a/Documentation/devicetree/bindings/net/macb.txt
> >> +++ b/Documentation/devicetree/bindings/net/macb.txt
> >> @@ -3,8 +3,7 @@
> >> Required properties:
> >> - compatible: Should be "cdns,[<chip>-]{macb|gem}"
> >> Use "cdns,at91rm9200-emac" Atmel at91rm9200 SoC.
> >> - Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs or the 10/100Mbit IP
> >> - available on sama5d3 SoCs.
> >> + Use "cdns,at91sam9260-macb" for Atmel at91sam9 SoCs.
> >
> > Where is "atmel,sama5d3-macb"?
>
> It's actually a couple of line below: line 13 of the resulting macb.txt
> file. It was already in the file when I removed the leftovers.
>
> Do you advice to try to better sort entries in this file? Is there a
> common pattern?
Okay, it's fine.
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-01-22 13:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 9:57 [PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC Nicolas Ferre
2019-01-16 9:57 ` [PATCH 1/8] dt-bindings: arm: atmel: add missing samx7 to reset controller Nicolas Ferre
2019-01-22 1:05 ` Rob Herring
2019-01-16 9:57 ` [PATCH 2/8] dt-bindings: arm: atmel: add new sam9x60 reset controller binding Nicolas Ferre
2019-01-22 1:07 ` Rob Herring
2019-01-22 9:00 ` Nicolas.Ferre
2019-01-22 13:40 ` Rob Herring
2019-01-16 9:57 ` [PATCH 3/8] dt-bindings: arm: atmel: add new sam9x60 SFR binding Nicolas Ferre
2019-01-16 9:57 ` [PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface Nicolas Ferre
2019-01-22 1:10 ` Rob Herring
2019-01-22 9:08 ` Nicolas.Ferre
2019-01-22 13:41 ` Rob Herring [this message]
2019-01-16 9:57 ` [PATCH 5/8] net/macb: bindings doc: add sam9x60 binding Nicolas Ferre
2019-01-16 9:57 ` [PATCH 6/8] power: reset: at91-reset: add support for sam9x60 SoC Nicolas Ferre
2019-01-23 18:34 ` Sebastian Reichel
2019-01-24 10:34 ` Nicolas.Ferre
2019-01-24 17:11 ` Sebastian Reichel
2019-01-16 9:57 ` [PATCH 7/8] USB: host: ohci-at91: add sam9x60-sfr definition for ohci Nicolas Ferre
2019-01-16 9:57 ` [PATCH 8/8] net: macb: add sam9x60-macb compatibility string Nicolas Ferre
2019-01-25 9:16 ` Nicolas.Ferre
2019-02-06 17:51 ` [PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC Nicolas.Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+31C2KXNy_GeVU9g7mZ_aSw3yqdjU-V5mV2Xdc200TuA@mail.gmail.com \
--to=robh@kernel.org \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sre@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).