From: Rob Herring <robh+dt@kernel.org>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Frank Rowand <frowand.list@gmail.com>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [RFC PATCH 04/12] of: base: introduce of_match_string()
Date: Mon, 8 Feb 2021 17:52:27 -0600 [thread overview]
Message-ID: <CAL_JsqKQyLcnHd-ff7z=Kk3D7scN-MGA0jKk1iwHnZj747cgGw@mail.gmail.com> (raw)
In-Reply-To: <20210208222203.22335-5-info@metux.net>
On Mon, Feb 8, 2021 at 4:24 PM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Introduce a new helper function that looks up a given propery and
typo
> matches all string elements against a given string. This is useful
> if we want to check wether one string element of some property
typo
> matches a given string.
Is there a user? Didn't see one in the series, but may have missed it.
I'd think we have some existing cases that could be converted.
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/of/base.c | 32 ++++++++++++++++++++++++++++++++
> include/linux/of.h | 2 ++
> 2 files changed, 34 insertions(+)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index e5ef611ed233..649c2a32bb48 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -287,6 +287,38 @@ const void *of_get_property(const struct device_node *np, const char *name,
> EXPORT_SYMBOL(of_get_property);
>
> /*
> + * of_match_string - match a propery against given string
> + * @node: device_node to look up at
> + * @name: name of the property
> + * @value: value to match against
> + *
> + * Look for property by name and match all string elements against value.
> + * Returns true if the property exists and any one of the string elements
> + * matches the given value.
> + */
> +bool of_match_string(const struct device_node *node, const char* name,
> + const char* value)
> +{
> + struct property *prop;
> + const char *walk;
> +
> + if (!name || !value)
> + return false;
> +
> + prop = of_find_property(node, name, NULL);
> + if (!prop)
> + return false;
> +
> + for (walk=of_prop_next_string(prop, NULL); walk;
> + walk=of_prop_next_string(prop, walk)) {
> + if (strcmp(walk, value)==0)
> + return true;
> + }
> + return true;
> +}
> +EXPORT_SYMBOL_GPL(of_match_string);
> +
> +/*
> * arch_match_cpu_phys_id - Match the given logical CPU and physical id
> *
> * @cpu: logical cpu index of a core/thread
> diff --git a/include/linux/of.h b/include/linux/of.h
> index dbf2c7442389..3612429632f4 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -355,6 +355,8 @@ extern bool of_device_is_big_endian(const struct device_node *device);
> extern const void *of_get_property(const struct device_node *node,
> const char *name,
> int *lenp);
> +extern bool of_match_string(const struct device_node *node, const char* name,
> + const char* value);
> extern struct device_node *of_get_cpu_node(int cpu, unsigned int *thread);
> extern struct device_node *of_get_next_cpu_node(struct device_node *prev);
> extern struct device_node *of_get_cpu_state_node(struct device_node *cpu_node,
> --
> 2.11.0
>
next prev parent reply other threads:[~2021-02-08 23:53 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 22:21 RFC: oftree based setup of composite board devices Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 01/12] of: base: improve error message in of_phandle_iterator_next() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 02/12] of: base: introduce of_find_node_by_phandle_from() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 03/12] of: base: record root node in interator and use it for phandle lookup Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 04/12] of: base: introduce of_match_string() Enrico Weigelt, metux IT consult
2021-02-08 23:52 ` Rob Herring [this message]
2021-02-08 22:21 ` [RFC PATCH 05/12] of: kobj: __of_attach_node_sysfs(): add optional basename parameter Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 06/12] of: kobj: introduce of_attach_tree_sysfs() Enrico Weigelt, metux IT consult
2021-02-08 22:21 ` [RFC PATCH 07/12] gpio: amd-fch: add oftree probing support Enrico Weigelt, metux IT consult
2021-02-11 9:57 ` Bartosz Golaszewski
2021-03-01 14:51 ` Linus Walleij
2021-03-11 10:17 ` Enrico Weigelt, metux IT consult
2021-03-11 10:42 ` Andy Shevchenko
2021-03-18 8:00 ` Enrico Weigelt, metux IT consult
2021-03-25 9:09 ` Linus Walleij
2021-02-08 22:21 ` [RFC PATCH 08/12] drivers: base: introduce bus_remove_device_by_name() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 09/12] drivers: base: reintroduce find_bus() Enrico Weigelt, metux IT consult
2021-02-13 10:20 ` Greg KH
2021-02-23 20:13 ` Enrico Weigelt, metux IT consult
2021-02-24 8:00 ` Greg KH
2021-02-24 15:30 ` Enrico Weigelt, metux IT consult
2021-02-24 16:28 ` Greg KH
2021-02-08 22:22 ` [RFC PATCH 10/12] export bus_get() / bus_put() Enrico Weigelt, metux IT consult
2021-02-08 22:22 ` [RFC PATCH 11/12] platform/x86: skeleton for oftree based board device initialization Enrico Weigelt, metux IT consult
2021-02-10 10:32 ` Andy Shevchenko
2021-02-12 9:58 ` Linus Walleij
2021-02-12 11:54 ` Enrico Weigelt, metux IT consult
2021-02-15 1:18 ` Frank Rowand
2021-02-23 20:41 ` Enrico Weigelt, metux IT consult
2021-03-02 13:33 ` Linus Walleij
2021-02-08 22:22 ` [RFC PATCH 12/12] platform/x86/of: add support for PC Engines APU v2/3/4 boards Enrico Weigelt, metux IT consult
2021-02-09 0:06 ` Rob Herring
2021-02-11 13:15 ` Enrico Weigelt, metux IT consult
2021-03-01 14:55 ` Linus Walleij
2021-02-08 23:48 ` RFC: oftree based setup of composite board devices Rob Herring
2021-02-10 22:13 ` Enrico Weigelt, metux IT consult
2021-02-15 1:12 ` Frank Rowand
2021-02-15 15:35 ` Andy Shevchenko
2021-02-24 13:00 ` Enrico Weigelt, metux IT consult
2021-02-24 23:14 ` Frank Rowand
2021-03-05 18:29 ` Rob Herring
2021-02-10 10:30 ` Andy Shevchenko
2021-02-11 11:08 ` Enrico Weigelt, metux IT consult
2021-02-11 11:41 ` Andy Shevchenko
2021-02-11 17:01 ` Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKQyLcnHd-ff7z=Kk3D7scN-MGA0jKk1iwHnZj747cgGw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).