From: Rob Herring <robh+dt@kernel.org>
To: Saravana Kannan <saravanak@google.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Frank Rowand <frowand.list@gmail.com>,
netdev <netdev@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>
Subject: Re: [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property
Date: Mon, 23 Aug 2021 17:08:25 -0500 [thread overview]
Message-ID: <CAL_JsqKXR=Kkx+yKcYv7R3uAeff_HLKSPGr5Y2RBC_=VJmypJQ@mail.gmail.com> (raw)
In-Reply-To: <CAGETcx8j+bOPL_-qFzHHJkX41Ljzq8HBkbBqtd4E0-2u6a3_Hg@mail.gmail.com>
On Mon, Aug 23, 2021 at 3:49 PM Saravana Kannan <saravanak@google.com> wrote:
>
> On Mon, Aug 23, 2021 at 12:58 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > > PHY seems to be one of those cases where it's okay to have the
> > > compatible property but also okay to not have it.
> >
> > Correct. They are like PCI or USB devices. You can ask it, what are
> > you? There are two registers in standard locations which give you a
> > vendor and product ID. We use that to find the correct driver.
>
> For all the cases of PHYs that currently don't need any compatible
> string, requiring a compatible string of type "ethernet-phy-standard"
> would have been nice. That would have made PHYs consistent with the
> general DT norm of "you need a compatible string to be matched with
> the device". Anyway, it's too late to do that now. So I'll have to
> deal with this some other way (I have a bunch of ideas, so it's not
> the end of the world).
This is not the first time the need for compatible strings for MDIO
devices has come up, but MDIO devices are special (evidently). I
should have taken a harder stance on this which should be simply, if
your device requires having a node in DT, then it requires a
compatible string.
Rob
next prev parent reply other threads:[~2021-08-23 22:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 2:17 [PATCH v2] of: property: fw_devlink: Add support for "phy-handle" property Saravana Kannan
2021-08-18 17:00 ` Rob Herring
[not found] ` <CGME20210823120849eucas1p11d3919886444358472be3edd1c662755@eucas1p1.samsung.com>
2021-08-23 12:08 ` Marek Szyprowski
2021-08-23 12:42 ` Rob Herring
2021-08-23 13:16 ` Andrew Lunn
2021-08-23 18:13 ` Saravana Kannan
2021-08-23 19:50 ` Andrew Lunn
2021-08-24 6:52 ` Marek Szyprowski
2021-08-23 18:22 ` Saravana Kannan
2021-08-23 19:58 ` Andrew Lunn
2021-08-23 20:48 ` Saravana Kannan
2021-08-23 22:01 ` Andrew Lunn
2021-08-23 22:08 ` Rob Herring [this message]
2021-08-24 7:03 ` Marek Szyprowski
2021-08-24 7:31 ` Saravana Kannan
2021-09-01 2:37 ` Saravana Kannan
2021-09-01 7:22 ` Marek Szyprowski
2021-09-08 21:58 ` [PATCH v1] RFC: of: property: fix phy-hanlde issue Saravana Kannan
2021-09-09 8:03 ` Marek Szyprowski
2021-09-14 0:54 ` Saravana Kannan
2021-09-14 4:44 ` Saravana Kannan
2021-09-14 6:15 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKXR=Kkx+yKcYv7R3uAeff_HLKSPGr5Y2RBC_=VJmypJQ@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kernel-team@android.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).