From: Firoz Khan <firoz.khan@linaro.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Chris Zankel <chris@zankel.net>,
linux-xtensa@linux-xtensa.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files
Date: Wed, 7 Nov 2018 10:31:32 +0530 [thread overview]
Message-ID: <CALxhOngnAHO16CTiqseAJD8q3TDX6Js6M+ZLwTLudT5RvTcLDQ@mail.gmail.com> (raw)
In-Reply-To: <CAMo8BfJcUuC1tcrZNf+6_iRA0esj5QrGFViMMeR3NPw6G5GbFA@mail.gmail.com>
Hi Max,
On Wed, 7 Nov 2018 at 01:54, Max Filippov <jcmvbkbc@gmail.com> wrote:
>
> Hi Firoz,
>
> On Tue, Nov 6, 2018 at 7:12 AM Firoz Khan <firoz.khan@linaro.org> wrote:
> > My initial patches does have generated-y += unistd_32.h instead of
> > generic-y += unistd_32.h.
> > If I remember someone pointed out that this implementation doesn't
> > look good. So I
> > replaced to generic-y += unistd_32.h.
>
> I've only found the following case, where you did the replacement:
> https://lkml.org/lkml/2018/8/9/177
> and I'm pretty sure that Michal meant that only the missing newline
> didn't look good.
>
> > Sure, I'll change to generated-y += unistd_32.h instead of generic-y
> > += unistd_32.h.
> >
> > Max, this looks ok. right?
>
> Yes, generated-y looks goodto me.
> Could you also please move the line
> generated-y += syscall_table.h
> up, so that alphabetical order of the header names is preserved?
Sure, will do.
Thanks
Firoz
>
> --
> Thanks.
> -- Max
next prev parent reply other threads:[~2018-11-07 5:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 13:56 [PATCH v1 0/4] xtensa: system call table generation support Firoz Khan
2018-11-01 13:56 ` [PATCH v1 1/4] xtensa: move SYS_XTENSA_* macros to non uapi header Firoz Khan
2018-11-05 21:28 ` Max Filippov
2018-11-06 2:29 ` Firoz Khan
2018-11-01 13:56 ` [PATCH v1 2/4] xtensa: add __NR_syscalls along with __NR_syscall_count Firoz Khan
2018-11-01 13:56 ` [PATCH v1 3/4] xtensa: add system call table generation support Firoz Khan
2018-11-01 13:56 ` [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files Firoz Khan
2018-11-05 21:44 ` Max Filippov
2018-11-06 4:21 ` Firoz Khan
2018-11-06 13:34 ` Arnd Bergmann
2018-11-06 15:12 ` Firoz Khan
2018-11-06 20:24 ` Max Filippov
2018-11-07 5:01 ` Firoz Khan [this message]
2018-11-06 20:30 ` [PATCH v1 0/4] xtensa: system call table generation support Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxhOngnAHO16CTiqseAJD8q3TDX6Js6M+ZLwTLudT5RvTcLDQ@mail.gmail.com \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=chris@zankel.net \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jcmvbkbc@gmail.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=pombredanne@nexb.com \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).