From: Firoz Khan <firoz.khan@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "open list:RALINK MIPS ARCHITECTURE" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Kate Stewart <kstewart@linuxfoundation.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
Subject: Re: [PATCH v3 1/6] mips: add __NR_syscalls along with __NR_Linux_syscalls
Date: Fri, 30 Nov 2018 10:15:48 +0530 [thread overview]
Message-ID: <CALxhOniC95bKe5vLvNFdjwrzLa+mWw6hMvzESXG3MkUfVsrOzA@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1Pq=Y83p-cN9bf+m-2ZAmJdEYRaAY9FfEkVHvfSwNWNg@mail.gmail.com>
Hi Arnd,
Thanks for your email.
On Thu, 29 Nov 2018 at 19:41, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Nov 29, 2018 at 9:44 AM Firoz Khan <firoz.khan@linaro.org> wrote:
>
> > arch/mips/include/uapi/asm/unistd.h | 17 ++++++++++++++---
> > 1 file changed, 14 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/mips/include/uapi/asm/unistd.h b/arch/mips/include/uapi/asm/unistd.h
> > index f25dd1d..6914be5 100644
> > --- a/arch/mips/include/uapi/asm/unistd.h
> > +++ b/arch/mips/include/uapi/asm/unistd.h
> > @@ -391,11 +391,14 @@
> > #define __NR_rseq (__NR_Linux + 367)
> > #define __NR_io_pgetevents (__NR_Linux + 368)
> >
> > +#ifdef __KERNEL__
> > +#define __NR_syscalls 368
> > +#endif
> >
> > /*
> > * Offset of the last Linux o32 flavoured syscall
> > */
> > -#define __NR_Linux_syscalls 368
> > +#define __NR_Linux_syscalls __NR_syscalls
>
> This seems odd: you define __NR_Linux_syscalls outside of
> #ifdef __KERNEL__, but the definition only works
> with __NR_syscalls being defined first, which it isn't in
> user space.
>
> Since the macros are completely unused as well as unusable
> now, how about removing them together with the other
> ones removed in patch 2?
Yes, good point, will update asap.
Firoz
>
> Arnd
next prev parent reply other threads:[~2018-11-30 4:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 8:43 [PATCH v3 0/6] mips: system call table generation support Firoz Khan
2018-11-29 8:43 ` [PATCH v3 1/6] mips: add __NR_syscalls along with __NR_Linux_syscalls Firoz Khan
2018-11-29 14:10 ` Arnd Bergmann
2018-11-30 4:45 ` Firoz Khan [this message]
2018-11-29 8:43 ` [PATCH v3 2/6] mips: remove unused macros Firoz Khan
2018-11-29 8:43 ` [PATCH v3 3/6] mips: add +1 to __NR_syscalls in uapi header Firoz Khan
2018-11-29 8:43 ` [PATCH v3 4/6] mips: remove syscall table entries Firoz Khan
2018-11-29 8:43 ` [PATCH v3 5/6] mips: add system call table generation support Firoz Khan
2018-11-29 14:15 ` Arnd Bergmann
2018-11-30 5:05 ` Firoz Khan
2018-11-29 8:43 ` [PATCH v3 6/6] mips: generate uapi header and system call table files Firoz Khan
2018-11-29 14:22 ` Arnd Bergmann
2018-11-30 5:13 ` Firoz Khan
2018-12-04 4:03 ` [PATCH v3 0/6] mips: system call table generation support Firoz Khan
2018-12-05 6:34 ` Paul Burton
2018-12-05 7:12 ` Firoz Khan
2018-12-06 12:15 ` Maciej W. Rozycki
2018-12-06 16:19 ` Joseph Myers
2018-12-06 17:02 ` Maciej W. Rozycki
2018-12-06 17:20 ` Joseph Myers
2018-12-06 17:43 ` Maciej W. Rozycki
2018-12-06 18:10 ` Florian Weimer
2018-12-07 14:33 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALxhOniC95bKe5vLvNFdjwrzLa+mWw6hMvzESXG3MkUfVsrOzA@mail.gmail.com \
--to=firoz.khan@linaro.org \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jhogan@kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marcin.juszkiewicz@linaro.org \
--cc=paul.burton@mips.com \
--cc=pombredanne@nexb.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).