From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFE9C4363A for ; Tue, 6 Oct 2020 01:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4270B20FC3 for ; Tue, 6 Oct 2020 01:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601948280; bh=uI6Ja7gDja+Igw5mOt4vFq/64xxqp+6cFo82h6FjCJk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=KwODPUYO47kfMJ+O1m4ldVgmR1t7f/cDjJbeMsI28PzjnVosLw76b3NfxXRnjzkek eWX1VNGvB0u+jVDB27c4wXCDwF59Liaes5GGTi+yhljNWlIMgwKYUNfImItq5vFAEc j/yGMBgwHuBQCZvSd1Hhr4HynX3fpuZVDE8t0K/U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726615AbgJFBh7 (ORCPT ); Mon, 5 Oct 2020 21:37:59 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:38731 "EHLO mail-wr1-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725872AbgJFBh6 (ORCPT ); Mon, 5 Oct 2020 21:37:58 -0400 Received: by mail-wr1-f52.google.com with SMTP id n18so3781499wrs.5 for ; Mon, 05 Oct 2020 18:37:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6XOkPuWAVksaYnpbdbI4+rs3vKcq8+w0HL/+QULyvzU=; b=r5OCtM1z6p8rULJ789sR8KLSRUWKRJDfjifaeEkv08sWJNDZprpjDk11TBTF9JeRzq VGOVwg4lpok3gvVs6HVKGQYYLxe057Qsn9UJuZd6668D8DwqZWSeQ+ZXwoi0dsdE5BOg EwrOb/6LOHl0NjJfaqLjOxSsCHPuxReauDz3v07njvKTxeHV+O0moCXMLxFIlz5hJgzO i4bJEAtHOm3eKHIML7Yiqa4H1dp12zIN8+y8M+bhchUWQegL+UiSwyXZXAFvSqYAoM3g rZAxP+dsbwfENLC3m917ePHmQDhw0Or0xnMvkQjUkrSCN7I/iAA5aeNJCnbluHjEjbCW U3Zw== X-Gm-Message-State: AOAM532XiZ/HHcXU43n5R347O+57HYWIwAVRXpLPOyaCG4A8oB1qi22Z YqJWmUVBpRFavU2cUxqbEAWmoTPJLAaL2o5SpE8= X-Google-Smtp-Source: ABdhPJwyqVss08r0Zo5xGYxMyLycQbmJn+NVAdh2lAKksXH/11wR+PmwiR/6mxjK/uUXpj77zcVVGaFqpXuLfNdxxIk= X-Received: by 2002:adf:e481:: with SMTP id i1mr2021795wrm.391.1601948276735; Mon, 05 Oct 2020 18:37:56 -0700 (PDT) MIME-Version: 1.0 References: <20200930171512.3986425-1-jolsa@kernel.org> <20200930171512.3986425-2-jolsa@kernel.org> <20201001190530.GD3999500@krava> <20201002192944.GH3999500@krava> In-Reply-To: <20201002192944.GH3999500@krava> From: Namhyung Kim Date: Tue, 6 Oct 2020 10:37:45 +0900 Message-ID: Subject: Re: [PATCHv2 1/9] perf tools: Add build id shell test To: Jiri Olsa Cc: Ian Rogers , Jiri Olsa , Arnaldo Carvalho de Melo , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 3, 2020 at 4:29 AM Jiri Olsa wrote: > > On Fri, Oct 02, 2020 at 10:34:51AM -0700, Ian Rogers wrote: > > SNIP > > > > > + > > > > LIBJVMTI = libperf-jvmti.so > > > > > > > > ifndef NO_JVMTI > > > > @@ -756,6 +763,13 @@ $(OUTPUT)perf-read-vdsox32: perf-read-vdso.c util/find-map.c > > > > $(QUIET_CC)$(CC) -mx32 $(filter -static,$(LDFLAGS)) -Wall -Werror -o $@ perf-read-vdso.c > > > > endif > > > > > > > > +ifndef NO_BUILDID_EX > > > > +$(OUTPUT)buildid-ex-sha1: > > > > + $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=sha1 -o $@ -x c - > > > > +$(OUTPUT)buildid-ex-md5: > > > > + $(QUIET_LINK)echo 'int main(void) { return 0; }' | $(CC) -Wl,--build-id=md5 -o $@ -x c - > > > > +endif > > > > > > Can we just build them in the test shell script instead? > > it would solve the build-directory/install-directory > lookup search.. but it'd need to do detect compiler > and depend on it as Ian said > > do you have some other reason to compile it in test? No I just wanted to make it easy to find the binaries and assumed a compiler is available in the test machine (which is not true for my company setup.... :-/) But otherwise we should keep the binaries somewhere in the install directory.. Thanks Namhyung