From: Jinpu Wang <jinpu.wang@profitbricks.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable <stable@vger.kernel.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
konrad.wilk@oracle.com
Subject: Re: [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63
Date: Mon, 20 Aug 2018 10:05:49 +0200 [thread overview]
Message-ID: <CAMGffEk=6eVgB=A--FyooDoVPY4mEiOdf=yNnqdX4cF6Ud_NuA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1808181330380.2151@nanos.tec.linutronix.de>
On Sat, Aug 18, 2018 at 2:50 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> On Fri, 17 Aug 2018, Greg Kroah-Hartman wrote:
> > On Fri, Aug 17, 2018 at 02:39:00PM +0200, Jinpu Wang wrote:
> > >
> > > I found the problem, CONFIG_HOTPLUG_SMT is enable due to CONFIG_SMP,
> > > but I did explicitly enable CONFIG_HOTPLUG_CPU.
> > >
> > > That's why the smt dir is missing, and kernel panic when I boot with
> > > 'nosmt' or 'l1tf=full' probably also other combination.
> > >
> > > With CONFIG_HOTPLUG_CPU=y, it works fine so far.
> >
> > So do we need a new configuration dependancy here to resolve this
> > problem? Why is this not an issue in Linus's tree?
>
> That's probably the same problem on Linus tree. Have not tested it yet
> though. I'll have a look.
>
> Thanks,
>
> tglx
>
Yeah, it's the same problem on Linus tree.
Probably makes sense to do the following, I can sent a formal patch if
you think it's right thing to do:
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index b0312f8..8a52f0b 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -188,7 +188,7 @@ config X86
select HAVE_SYSCALL_TRACEPOINTS
select HAVE_UNSTABLE_SCHED_CLOCK
select HAVE_USER_RETURN_NOTIFIER
- select HOTPLUG_SMT if SMP
+ select HOTPLUG_SMT if SMP && HOTPLUG_CPU
select IRQ_FORCED_THREADING
select NEED_SG_DMA_LENGTH
select PCI_LOCKLESS_CONFIG
--
Jack Wang
Linux Kernel Developer
ProfitBricks GmbH
Greifswalder Str. 207
D - 10405 Berlin
Tel: +49 30 577 008 042
Fax: +49 30 577 008 299
Email: jinpu.wang@profitbricks.com
URL: https://www.profitbricks.de
Sitz der Gesellschaft: Berlin
Registergericht: Amtsgericht Charlottenburg, HRB 125506 B
Geschäftsführer: Achim Weiss, Matthias Steinberg, Christoph Steffens
next prev parent reply other threads:[~2018-08-20 8:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMGffEnzVo5VVSVBjCOBMhcoV1qXf0XXqJqr3C01xQn-aUiZFQ@mail.gmail.com>
[not found] ` <20180816155126.GA18296@kroah.com>
2018-08-16 16:28 ` [BUG]smt sysfs dir missing on 4.4.148 and 4.14.63 Jinpu Wang
2018-08-16 16:39 ` Greg Kroah-Hartman
[not found] ` <CAMGffEk2FqRn0av7T-aF-TKvRAKeinm96NYjJju_T4CmUrYPkQ@mail.gmail.com>
2018-08-17 12:39 ` Jinpu Wang
2018-08-17 17:01 ` Greg Kroah-Hartman
2018-08-18 12:50 ` Thomas Gleixner
2018-08-20 8:05 ` Jinpu Wang [this message]
2018-08-20 13:02 ` Thomas Gleixner
2018-08-20 13:20 ` Jinpu Wang
2018-08-20 14:47 ` Thomas Gleixner
2018-08-20 14:52 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMGffEk=6eVgB=A--FyooDoVPY4mEiOdf=yNnqdX4cF6Ud_NuA@mail.gmail.com' \
--to=jinpu.wang@profitbricks.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).