From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Cc: linux-kernel@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH] irq_work: improve the flag definitions
Date: Tue, 15 Aug 2017 11:12:31 +0200 [thread overview]
Message-ID: <CAMRc=MdLJJUy-q56ozER8m-QP--jQRRcNF2DBpExync1odNxxQ@mail.gmail.com> (raw)
In-Reply-To: <20170814115647.21955-1-brgl@bgdev.pl>
2017-08-14 13:56 GMT+02:00 Bartosz Golaszewski <brgl@bgdev.pl>:
> IRQ_WORK_FLAGS is defined simply to 3UL. This is confusing as it
> says nothing about its purpose. Define IRQ_WORK_FLAGS as a bitwise
> OR of IRQ_WORK_PENDING and IRQ_WORK_BUSY.
>
> While we're at it: use the BIT() macro for all flags.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
> include/linux/irq_work.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/irq_work.h b/include/linux/irq_work.h
> index 47b9ebd4a74f..467a58e7e0da 100644
> --- a/include/linux/irq_work.h
> +++ b/include/linux/irq_work.h
> @@ -12,10 +12,10 @@
> * busy NULL, 2 -> {free, claimed} : callback in progress, can be claimed
> */
>
> -#define IRQ_WORK_PENDING 1UL
> -#define IRQ_WORK_BUSY 2UL
> -#define IRQ_WORK_FLAGS 3UL
> -#define IRQ_WORK_LAZY 4UL /* Doesn't want IPI, wait for tick */
> +#define IRQ_WORK_PENDING BIT(0)
> +#define IRQ_WORK_BUSY BIT(1)
> +#define IRQ_WORK_FLAGS (IRQ_WORK_PENDING | IRQ_WORK_BUSY)
> +#define IRQ_WORK_LAZY BIT(3) /* Doesn't want IPI, wait for tick */
Superseded by v2 - 4UL is BIT(2), not BIT(3).
Best regards,
Bartosz Golaszewski
next prev parent reply other threads:[~2017-08-15 9:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 11:56 [PATCH] irq_work: improve the flag definitions Bartosz Golaszewski
2017-08-14 12:19 ` Andy Shevchenko
2017-08-14 17:12 ` Bartosz Golaszewski
2017-08-15 9:12 ` Bartosz Golaszewski [this message]
2018-01-05 4:19 [PATCH] irq_work: Improve " Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMRc=MdLJJUy-q56ozER8m-QP--jQRRcNF2DBpExync1odNxxQ@mail.gmail.com' \
--to=brgl@bgdev.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).