From: Muchun Song <songmuchun@bytedance.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Vlastimil Babka <vbabka@suse.cz>,
Linux Memory Management List <linux-mm@kvack.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>
Subject: Re: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior
Date: Wed, 26 May 2021 12:04:49 +0800 [thread overview]
Message-ID: <CAMZfGtVdzwjJLuUvcmgivKZNU1TK+ePFH9wgcm6jH86FWFHbJA@mail.gmail.com> (raw)
In-Reply-To: <20210526025625.601023-2-swboyd@chromium.org>
On Wed, May 26, 2021 at 10:56 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Passing slub_debug=- on the kernel commandline is supposed to disable
> slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON
> where the default is to have slub debugging enabled in the build. Due to
> some code reorganization this behavior was dropped, but the code to make
> it work mostly stuck around. Restore the previous behavior by disabling
> the static key when we parse the commandline and see that we're trying
> to disable slub debugging.
>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks")
Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static
key for slub_debug()")?
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> mm/slub.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 438fa8d4c970..2f53e8a9c28e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1396,6 +1396,8 @@ static int __init setup_slub_debug(char *str)
> out:
> if (slub_debug != 0 || slub_debug_string)
> static_branch_enable(&slub_debug_enabled);
> + else
> + static_branch_disable(&slub_debug_enabled);
> if ((static_branch_unlikely(&init_on_alloc) ||
> static_branch_unlikely(&init_on_free)) &&
> (slub_debug & SLAB_POISON))
> --
> https://chromeos.dev
>
next prev parent reply other threads:[~2021-05-26 4:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 2:56 [PATCH v2 0/4] slub: Print non-hashed pointers in slub debugging Stephen Boyd
2021-05-26 2:56 ` [PATCH v2 1/4] slub: Restore slub_debug=- behavior Stephen Boyd
2021-05-26 4:04 ` Muchun Song [this message]
2021-05-26 10:39 ` [External] " Vlastimil Babka
2021-05-26 20:20 ` Stephen Boyd
2021-05-27 2:51 ` Muchun Song
2021-05-26 2:56 ` [PATCH v2 2/4] slub: Actually use 'message' in restore_bytes() Stephen Boyd
2021-05-26 3:29 ` [External] " Muchun Song
2021-05-26 2:56 ` [PATCH v2 3/4] slub: Indicate slab_fix() uses printf formats Stephen Boyd
2021-05-26 10:40 ` Vlastimil Babka
2021-05-26 2:56 ` [PATCH v2 4/4] slub: Force on no_hash_pointers when slub_debug is enabled Stephen Boyd
2021-05-26 5:40 ` kernel test robot
2021-05-26 7:54 ` kernel test robot
2021-05-26 10:48 ` Vlastimil Babka
2021-05-26 13:47 ` Petr Mladek
2021-05-26 19:27 ` Stephen Boyd
2021-05-31 9:28 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMZfGtVdzwjJLuUvcmgivKZNU1TK+ePFH9wgcm6jH86FWFHbJA@mail.gmail.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=swboyd@chromium.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).