From: Peter Geis <pgwipeout@gmail.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Frank Wunderlich <frank-w@public-files.de>,
Lee Jones <lee.jones@linaro.org>,
Robin Murphy <robin.murphy@arm.com>,
Heiko Stuebner <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Aw: [PATCH v3] mfd: rk808: add reboot support to rk808.c
Date: Mon, 20 Dec 2021 12:07:12 -0500 [thread overview]
Message-ID: <CAMdYzYoYU-Avi1RK_-gHBWqiWdnxH9Pwa5nnJkU1ZewHm-1OHw@mail.gmail.com> (raw)
In-Reply-To: <b0d0e2ff-4282-f104-b8f5-554b059200c9@gmail.com>
On Mon, Dec 20, 2021 at 11:36 AM Dmitry Osipenko <digetx@gmail.com> wrote:
>
> 20.12.2021 19:33, Frank Wunderlich пишет:
> > Hi
> >
> >> Gesendet: Montag, 20. Dezember 2021 um 15:46 Uhr
> >> Von: "Peter Geis" <pgwipeout@gmail.com>
> >> @@ -749,6 +791,9 @@ static int rk808_remove(struct i2c_client *client)
> >> if (pm_power_off == rk808_pm_power_off)
> >> pm_power_off = NULL;
> >>
> >> + if (of_property_read_bool(np, "rockchip,system-power-controller"))
> >> + unregister_restart_handler(&rk808_restart_handler);
> >> +
> >> return 0;
> >> }
> >
> > this change misses a declaration
> >
> > struct device_node *np = client->dev.of_node;
>
> Good catch, technically the whole of_property_read_bool() could be
> dropped from rk808_remove() since unregister_restart_handler() survives
> if handler wasn't registered.
Thank you all!
next prev parent reply other threads:[~2021-12-20 17:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 14:46 [PATCH v3] mfd: rk808: add reboot support to rk808.c Peter Geis
2021-12-20 14:53 ` Dmitry Osipenko
2021-12-20 16:33 ` Aw: " Frank Wunderlich
2021-12-20 16:36 ` Dmitry Osipenko
2021-12-20 17:07 ` Peter Geis [this message]
2021-12-21 8:48 ` Lee Jones
2021-12-21 9:10 ` Frank Wunderlich
2021-12-22 11:09 ` Lee Jones
2021-12-22 11:31 ` Aw: " Frank Wunderlich
2021-12-22 12:53 ` Lee Jones
2021-12-22 13:19 ` Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMdYzYoYU-Avi1RK_-gHBWqiWdnxH9Pwa5nnJkU1ZewHm-1OHw@mail.gmail.com \
--to=pgwipeout@gmail.com \
--cc=digetx@gmail.com \
--cc=frank-w@public-files.de \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).