From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Gregory Fong" <gregory.0xf0@gmail.com>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"René van Dorst" <opensource@vdorst.com>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"John Thomson" <git@johnthomson.fastmail.com.au>,
NeilBrown <neil@brown.name>,
"Nicholas Mc Guire" <hofrat@osadl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip per device
Date: Tue, 27 Jul 2021 08:02:01 +0200 [thread overview]
Message-ID: <CAMhs-H9fbHMxxSaqMj=nyACAN6aDB-bYK1nF1dRh8a1krTdaZg@mail.gmail.com> (raw)
In-Reply-To: <20210708070429.31871-1-sergio.paracuellos@gmail.com>
On Thu, Jul 8, 2021 at 9:04 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:
>
> There are some unfortunate cases where the DT representation
> of the device and the Linux internal representation differs.
> Such drivers for devices are forced to implement a custom function
> to avoid the core code 'devprop_gpiochip_set_names' to be executed
> since in any other case every gpiochip inside will got repeated
> names through its internal gpiochip banks. To avoid this antipattern
> this changes are introduced trying to adapt core 'devprop_gpiochip_set_names'
> to get a correct behaviour for every single situation.
>
> This series introduces a new 'offset' field in the gpiochip structure
> that can be used for those unfortunate drivers that must define multiple
> gpiochips per device.
>
> Drivers affected by this situation are also updated. These are
> 'gpio-mt7621' and 'gpio-brcmstb'.
>
> Motivation for this series available at [0].
>
> Thanks in advance for your feedback.
>
> Best regards,
> Sergio Paracuellos
>
> [0]: https://lkml.org/lkml/2021/6/26/198
>
> Sergio Paracuellos (3):
> gpiolib: convert 'devprop_gpiochip_set_names' to support multiple
> gpiochip baks per device
> gpio: mt7621: support gpio-line-names property
> gpio: brcmstb: remove custom 'brcmstb_gpio_set_names'
>
> drivers/gpio/gpio-brcmstb.c | 45 +------------------------------------
> drivers/gpio/gpio-mt7621.c | 1 +
> drivers/gpio/gpiolib.c | 34 +++++++++++++++++++++++-----
> include/linux/gpio/driver.h | 4 ++++
> 4 files changed, 34 insertions(+), 50 deletions(-)
Hi!
Linus, Bartosz, any comments on this series?
Best regards,
Sergio Paracuellos
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-07-27 6:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 7:04 [PATCH 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip per device Sergio Paracuellos
2021-07-08 7:04 ` [PATCH 1/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip baks " Sergio Paracuellos
2021-07-19 7:57 ` Gregory Fong
2021-07-19 8:31 ` Sergio Paracuellos
2021-07-27 7:39 ` Gregory Fong
2021-07-27 11:42 ` Sergio Paracuellos
2021-07-08 7:04 ` [PATCH 2/3] gpio: mt7621: support gpio-line-names property Sergio Paracuellos
2021-07-08 7:04 ` [PATCH 3/3] gpio: brcmstb: remove custom 'brcmstb_gpio_set_names' Sergio Paracuellos
2021-07-19 7:59 ` Gregory Fong
2021-07-08 8:02 ` [PATCH 0/3] gpiolib: convert 'devprop_gpiochip_set_names' to support multiple gpiochip per device Andy Shevchenko
2021-07-08 8:40 ` Sergio Paracuellos
2021-07-27 6:02 ` Sergio Paracuellos [this message]
2021-07-27 11:35 ` Bartosz Golaszewski
2021-07-27 11:40 ` Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMhs-H9fbHMxxSaqMj=nyACAN6aDB-bYK1nF1dRh8a1krTdaZg@mail.gmail.com' \
--to=sergio.paracuellos@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=f.fainelli@gmail.com \
--cc=git@johnthomson.fastmail.com.au \
--cc=gregory.0xf0@gmail.com \
--cc=hofrat@osadl.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=neil@brown.name \
--cc=opensource@vdorst.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).