From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753546Ab2HaNg3 (ORCPT ); Fri, 31 Aug 2012 09:36:29 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:37555 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923Ab2HaNg2 (ORCPT ); Fri, 31 Aug 2012 09:36:28 -0400 MIME-Version: 1.0 In-Reply-To: <1346413543.9709.45.camel@sauron.fi.intel.com> References: <1346001700-26895-1-git-send-email-shijie8@gmail.com> <1346413543.9709.45.camel@sauron.fi.intel.com> Date: Fri, 31 Aug 2012 09:36:27 -0400 Message-ID: Subject: Re: [PATCH 1/3] mtd: cmdlinepart: make the partitions rule more strict From: Huang Shijie To: dedekind1@gmail.com Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, shmulik.ladkani@gmail.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 31, 2012 at 7:45 AM, Artem Bityutskiy wrote: > On Sun, 2012-08-26 at 13:21 -0400, Huang Shijie wrote: >> There are typically two types to set the mtd partitions: >> >> <1> set with the `size`, such as >> gpmi-nand:100m(boot),100m(kernel),1g(rootfs) >> >> <2> set with the `offset`, such as >> gpmi-nand:100m@0(boot),100m@100m(kernel),1g@200m(rootfs) >> gpmi-nand:1g@200m(rootfs),100m@0(boot),100m@100m(kernel) >> >> If we mix these two types, such as: >> gpmi-nand:100m@0(boot),100m(kernel),1g@200m(rootfs) >> gpmi-nand:1g@200m(rootfs),100m@0(boot),100m(kernel) >> >> It's hard to understand the cmdline. And also it is hard to sort the >> partitions in this mixed type. So we explicitly forbid the mixed type. > > So "explicitly forbid" is just to add a "do not do this" comment? > This is the simplest way. ;) It's make code complicated if we change the code to forbid this mixed type. Best Regards Huang Shijie