From: Ard Biesheuvel <ardb@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, Randy Dunlap <rdunlap@infradead.org>,
linux-kbuild@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
afzal mohammed <afzal.mohd.ma@gmail.com>,
linux-efi <linux-efi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ia64: remove unneeded header includes from <asm/mca.h>
Date: Mon, 31 Aug 2020 18:00:18 +0300 [thread overview]
Message-ID: <CAMj1kXF6-oFD3t4FkieLYRxB8gHpEAPnW+APouW0+AKb8ZXhvw@mail.gmail.com> (raw)
In-Reply-To: <20200829051524.706585-3-masahiroy@kernel.org>
On Sat, 29 Aug 2020 at 08:16, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> <asm/mca.h> includes too many unneeded headers.
>
> This commit cuts off a lot of header includes.
>
> What we need to include are:
>
> - <linux/percpu.h> for DECLARE_PER_CPU(u64, ia64_mca_pal_base)
> - <linux/threads.h> for NR_CPUS
> - <linux/types.h> for u8, u64, size_t, etc.
> - <asm/ptrace.h> for KERNEL_STACK_SIZE
>
> The other header includes are actually unneeded.
>
> <asm/mca.h> previously included 436 headers, and now it includes
> only 138. I confirmed <asm/mca.h> is still self-contained.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>
> arch/ia64/include/asm/mca.h | 9 +++------
> arch/ia64/kernel/efi.c | 1 +
> arch/ia64/kernel/mca.c | 1 +
> 3 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/arch/ia64/include/asm/mca.h b/arch/ia64/include/asm/mca.h
> index c92b9c15962c..05805249296c 100644
> --- a/arch/ia64/include/asm/mca.h
> +++ b/arch/ia64/include/asm/mca.h
> @@ -14,13 +14,10 @@
>
> #if !defined(__ASSEMBLY__)
>
> -#include <linux/interrupt.h>
> +#include <linux/percpu.h>
> +#include <linux/threads.h>
> #include <linux/types.h>
> -
> -#include <asm/param.h>
> -#include <asm/sal.h>
> -#include <asm/processor.h>
> -#include <asm/mca_asm.h>
> +#include <asm/ptrace.h>
>
> #define IA64_MCA_RENDEZ_TIMEOUT (20 * 1000) /* value in milliseconds - 20 seconds */
>
> diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
> index f932b25fb817..b6bb718ed1ff 100644
> --- a/arch/ia64/kernel/efi.c
> +++ b/arch/ia64/kernel/efi.c
> @@ -39,6 +39,7 @@
> #include <asm/meminit.h>
> #include <asm/processor.h>
> #include <asm/mca.h>
> +#include <asm/sal.h>
> #include <asm/setup.h>
> #include <asm/tlbflush.h>
>
> diff --git a/arch/ia64/kernel/mca.c b/arch/ia64/kernel/mca.c
> index 17151269d655..3911c561d2bb 100644
> --- a/arch/ia64/kernel/mca.c
> +++ b/arch/ia64/kernel/mca.c
> @@ -96,6 +96,7 @@
> #include <asm/ptrace.h>
> #include <asm/sal.h>
> #include <asm/mca.h>
> +#include <asm/mca_asm.h>
> #include <asm/kexec.h>
>
> #include <asm/irq.h>
> --
> 2.25.1
>
next prev parent reply other threads:[~2020-08-31 15:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 5:15 [PATCH 0/3] ia64: clean-up header dependency and build process, fix build warning Masahiro Yamada
2020-08-29 5:15 ` [PATCH 1/3] ia64: do not typedef struct pal_min_state_area_s Masahiro Yamada
2020-08-29 18:21 ` Randy Dunlap
2020-08-29 5:15 ` [PATCH 2/3] ia64: remove unneeded header includes from <asm/mca.h> Masahiro Yamada
2020-08-29 18:20 ` Randy Dunlap
2020-08-31 15:00 ` Ard Biesheuvel [this message]
2020-08-29 5:15 ` [PATCH 3/3] ia64: remove generated/nr-irqs.h generation to fix build warning Masahiro Yamada
2020-08-29 18:22 ` Randy Dunlap
2021-02-07 2:46 ` Masahiro Yamada
2020-12-04 5:43 ` [PATCH 0/3] ia64: clean-up header dependency and build process, " Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXF6-oFD3t4FkieLYRxB8gHpEAPnW+APouW0+AKb8ZXhvw@mail.gmail.com \
--to=ardb@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=afzal.mohd.ma@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rdunlap@infradead.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).