linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ardb@kernel.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Arnd Bergmann <arnd@arndb.de>, stable <stable@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>,
	Rikard Falkeborn <rikard.falkeborn@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: avoid static_assert for genksyms
Date: Mon, 7 Dec 2020 09:53:55 +0100	[thread overview]
Message-ID: <CAMj1kXGUxTf_Mezgna0S1LAQ4ANMHtCqUqc995NPwAiOp+-6Eg@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNAR50sq8O-5yg1O7760JAd3-GPHSLGGG=7kPtm9dbDDqwg@mail.gmail.com>

On Sun, 6 Dec 2020 at 03:49, Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Fri, Dec 4, 2020 at 8:10 AM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > genksyms does not know or care about the _Static_assert() built-in,
> > and sometimes falls back to ignoring the later symbols, which causes
> > undefined behavior such as
> >
> > WARNING: modpost: EXPORT symbol "ethtool_set_ethtool_phy_ops" [vmlinux] version generation failed, symbol will not be versioned.
> > ld: net/ethtool/common.o: relocation R_AARCH64_ABS32 against `__crc_ethtool_set_ethtool_phy_ops' can not be used when making a shared object
> > net/ethtool/common.o:(_ftrace_annotated_branch+0x0): dangerous relocation: unsupported relocation
> >
> > Redefine static_assert for genksyms to avoid that.
>
>
> Please tell the CONFIG options needed to reproduce this.
> I do not see it.
>

https://people.linaro.org/~ard.biesheuvel/randconfig-modversions-error

  reply	other threads:[~2020-12-07  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 23:09 [PATCH] kbuild: avoid static_assert for genksyms Arnd Bergmann
2020-12-06  2:48 ` Masahiro Yamada
2020-12-07  8:53   ` Ard Biesheuvel [this message]
2020-12-10 16:12 ` Marco Elver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMj1kXGUxTf_Mezgna0S1LAQ4ANMHtCqUqc995NPwAiOp+-6Eg@mail.gmail.com \
    --to=ardb@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=keescook@chromium.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=rikard.falkeborn@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).