From: Max Filippov <jcmvbkbc@gmail.com>
To: Corentin Labbe <clabbe@baylibre.com>
Cc: Chris Zankel <chris@zankel.net>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH] xtensa: rename BUILTIN_DTB to BUILTIN_DTB_SOURCE
Date: Fri, 25 Jan 2019 12:51:30 -0800 [thread overview]
Message-ID: <CAMo8Bf+1ePb+AfN1c-5sREYHr93bg4dbtTRtKHKrdbvQSPr2zg@mail.gmail.com> (raw)
In-Reply-To: <1548236958-17565-1-git-send-email-clabbe@baylibre.com>
On Wed, Jan 23, 2019 at 1:49 AM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> When building some xtensa config, I hit the following warning:
> drivers/staging/mt7621-dts/Kconfig:4:warning: 'BUILTIN_DTB' has wrong type. 'select' only accept arguments of bool and tristate type
>
> It is due to some arch use BUILTIN_DTB as a flag for the need to builtin
> dtb but xtensa use it as a string for which dtb to bulltin.
> But for this (which dtb to build), it is better to use
> BUILTIN_DTB_SOURCE like other arch do.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> arch/xtensa/Kconfig | 2 +-
> arch/xtensa/boot/dts/Makefile | 6 +++---
> arch/xtensa/configs/audio_kc705_defconfig | 2 +-
> arch/xtensa/configs/cadence_csp_defconfig | 2 +-
> arch/xtensa/configs/generic_kc705_defconfig | 2 +-
> arch/xtensa/configs/nommu_kc705_defconfig | 2 +-
> arch/xtensa/configs/smp_lx200_defconfig | 2 +-
> 7 files changed, 9 insertions(+), 9 deletions(-)
Thanks, applied to my xtensa tree after reformatting commit message a bit.
--
Thanks.
-- Max
prev parent reply other threads:[~2019-01-25 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-23 9:49 [PATCH] xtensa: rename BUILTIN_DTB to BUILTIN_DTB_SOURCE Corentin Labbe
2019-01-23 19:33 ` Max Filippov
2019-01-25 20:51 ` Max Filippov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMo8Bf+1ePb+AfN1c-5sREYHr93bg4dbtTRtKHKrdbvQSPr2zg@mail.gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=chris@zankel.net \
--cc=clabbe@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).