From: Max Filippov <jcmvbkbc@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"open list:TENSILICA XTENSA PORT (xtensa)"
<linux-xtensa@linux-xtensa.org>,
LKML <linux-kernel@vger.kernel.org>,
Chris Zankel <chris@zankel.net>
Subject: Re: [PATCH] xtensa: Increase size of gcc stack frame check
Date: Sat, 11 Sep 2021 22:16:51 -0700 [thread overview]
Message-ID: <CAMo8BfK0+G01bw9UQ=fgGy3fNV+69NwUcpAO3msX0+FU4zKttQ@mail.gmail.com> (raw)
In-Reply-To: <49f8f332-a964-5b98-64c6-9fa5d028731a@roeck-us.net>
On Sat, Sep 11, 2021 at 9:02 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 9/11/21 8:05 PM, Max Filippov wrote:
> > On Sat, Sep 11, 2021 at 7:52 PM Guenter Roeck <linux@roeck-us.net> wrote:
> >>
> >> xtensa frame size is larger than the frame size for almost all other
> >> architectures. This results in more than 50 "the frame size of <n> is
> >> larger than 1024 bytes" errors when trying to build xtensa:allmodconfig.
> >>
> >> Increase frame size for xtensa to 1536 bytes to avoid compile errors
> >> due to frame size limits.
> >>
> >> Cc: Chris Zankel <chris@zankel.net>
> >> Cc: Max Filippov <jcmvbkbc@gmail.com>
> >> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> >> ---
> >> lib/Kconfig.debug | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> >> index ed4a31e34098..afad11e57d6b 100644
> >> --- a/lib/Kconfig.debug
> >> +++ b/lib/Kconfig.debug
> >> @@ -346,7 +346,7 @@ config FRAME_WARN
> >> int "Warn for stack frames larger than"
> >> range 0 8192
> >> default 2048 if GCC_PLUGIN_LATENT_ENTROPY
> >> - default 1536 if (!64BIT && PARISC)
> >> + default 1536 if (!64BIT && (PARISC || XTENSA))
> >> default 1024 if (!64BIT && !PARISC)
> >
> > Shouldn't that line also be changed to
> > default 1024 if (!64BIT && !(PARISC || XTENSA))
> > ?
>
> I could do that, but I tested it and it looks like the evaluation
> is top-down, so it didn't seem necessary or useful. For example,
> the default value is 2048 for 32-bit systems (such as arm, riscv32,
> or i386) if GCC_PLUGIN_LATENT_ENTROPY is enabled, even though the
> line with the default of 1024 matches as well.
Reviewed-by: Max Filippov <jcmvbkbc@gmail.com>
--
Thanks.
-- Max
next prev parent reply other threads:[~2021-09-12 5:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 2:52 [PATCH] xtensa: Increase size of gcc stack frame check Guenter Roeck
2021-09-12 3:05 ` Max Filippov
2021-09-12 4:02 ` Guenter Roeck
2021-09-12 5:16 ` Max Filippov [this message]
2021-09-13 15:57 ` David Laight
2021-09-13 16:11 ` Guenter Roeck
2021-09-14 7:04 ` Max Filippov
2021-09-14 14:02 ` Guenter Roeck
2021-09-14 17:24 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMo8BfK0+G01bw9UQ=fgGy3fNV+69NwUcpAO3msX0+FU4zKttQ@mail.gmail.com' \
--to=jcmvbkbc@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chris@zankel.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@roeck-us.net \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).