From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Linux PM list <linux-pm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Kevin Hilman <khilman@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider
Date: Fri, 9 Jul 2021 15:06:48 +0200 [thread overview]
Message-ID: <CAMuHMdU0AVFVb3tXW4wkEibSx50nzYKW1GopgZPfKp1SS7Mf1g@mail.gmail.com> (raw)
In-Reply-To: <20210709125611.135920-1-ulf.hansson@linaro.org>
Hi Ulf,
Thanks for your patch!
On Fri, Jul 9, 2021 at 2:56 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> According to the common power domain DT bindings, a power domain provider
> must have a "#power-domain-cells" property in its OF node. Additionally, if
> a provider has a "power-domains" property, it means that it has a parent
> domain.
OK.
> It has turned out that some OF nodes that represents a genpd provider may
> also be compatible with a regular platform device. This leads to, during
> probe, genpd_dev_pm_attach(), genpd_dev_pm_attach_by_name() and
> genpd_dev_pm_attach_by_id() tries to attach the corresponding struct device
> to the genpd provider's parent domain, which is wrong. Instead the genpd
Why is that wrong?
> provider should only assign a parent domain, through
> pm_genpd_add_subdomain() or of_genpd_add_subdomain().
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2021-07-09 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 12:56 [PATCH] PM: domains: Don't attach a device to genpd that corresponds to a provider Ulf Hansson
2021-07-09 13:06 ` Geert Uytterhoeven [this message]
2021-07-09 13:22 ` Ulf Hansson
2021-07-09 13:35 ` Geert Uytterhoeven
2021-07-09 13:48 ` Ulf Hansson
2021-07-09 13:57 ` Geert Uytterhoeven
2021-07-09 14:02 ` Ulf Hansson
2021-07-09 13:46 ` Bjorn Andersson
2021-07-09 13:58 ` Ulf Hansson
2021-07-09 14:16 ` Bjorn Andersson
2021-07-09 18:49 ` kernel test robot
2021-07-09 19:01 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdU0AVFVb3tXW4wkEibSx50nzYKW1GopgZPfKp1SS7Mf1g@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).