From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alexandru Stan <amstan@chromium.org>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Andy Gross" <agross@kernel.org>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Douglas Anderson" <dianders@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>,
"Matthias Kaehlcke" <mka@chromium.org>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Linux Fbdev development list" <linux-fbdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux PWM List" <linux-pwm@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] backlight: pwm_bl: Fix interpolation
Date: Thu, 15 Oct 2020 08:54:57 +0200 [thread overview]
Message-ID: <CAMuHMdUSWWSVQCxX-rv3MCvw59q+dscQ3bC4yysVCPyxdaEi6w@mail.gmail.com> (raw)
In-Reply-To: <20201013010056.v2.1.I4dcea1c90e9da3902d466033aa73351e19e49c49@changeid>
Hi Alexandru,
On Tue, Oct 13, 2020 at 1:57 PM Alexandru Stan <amstan@chromium.org> wrote:
> Whenever num-interpolated-steps was larger than the distance
> between 2 consecutive brightness levels the table would get really
> discontinuous. The slope of the interpolation would stick with
> integers only and if it was 0 the whole line segment would get skipped.
>
> Example settings:
> brightness-levels = <0 1 2 4 8 16 32 64 128 256>;
> num-interpolated-steps = <16>;
>
> The distances between 1 2 4 and 8 would be 1, and only starting with 16
> it would start to interpolate properly.
>
> Let's change it so there's always interpolation happening, even if
> there's no enough points available (read: values in the table would
> appear more than once). This should match the expected behavior much
> more closely.
>
> Signed-off-by: Alexandru Stan <amstan@chromium.org>
Thanks for your patch!
> --- a/drivers/video/backlight/pwm_bl.c
> +++ b/drivers/video/backlight/pwm_bl.c
> @@ -327,24 +324,25 @@ static int pwm_backlight_parse_dt(struct device *dev,
> table = devm_kzalloc(dev, size, GFP_KERNEL);
> if (!table)
> return -ENOMEM;
> -
> - /* Fill the interpolated table. */
> - levels_count = 0;
> - for (i = 0; i < data->max_brightness - 1; i++) {
> - value = data->levels[i];
> - n = (data->levels[i + 1] - value) / num_steps;
> - if (n > 0) {
> - for (j = 0; j < num_steps; j++) {
> - table[levels_count] = value;
> - value += n;
> - levels_count++;
> - }
> - } else {
> - table[levels_count] = data->levels[i];
> - levels_count++;
> + /*
> + * Fill the interpolated table[x] = y
> + * by draw lines between each (x1, y1) to (x2, y2).
> + */
> + dx = num_steps;
> + for (i = 0; i < num_input_levels - 1; i++) {
> + x1 = i * dx;
> + x2 = x1 + dx;
> + y1 = data->levels[i];
> + y2 = data->levels[i + 1];
> + dy = (s64)y2 - y1;
> +
> + for (x = x1; x < x2; x++) {
> + table[x] = y1 +
> + div_s64(dy * ((s64)x - x1), dx);
Yummy, 64-by-32 divisions.
Shouldn't this use a rounded division?
Nevertheless, I think it would be worthwhile to implement this using
a (modified) Bresenham algorithm, avoiding multiplications and
divisions, and possibly increasing accuracy as well.
https://en.wikipedia.org/wiki/Bresenham%27s_line_algorithm
> }
> }
> - table[levels_count] = data->levels[i];
> + /* Fill in the last point, since no line starts here. */
> + table[x2] = y2;
>
> /*
> * As we use interpolation lets remove current
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-10-15 6:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 8:01 [PATCH v2 0/3] PWM backlight interpolation adjustments Alexandru Stan
2020-10-13 8:01 ` [PATCH v2 1/3] backlight: pwm_bl: Fix interpolation Alexandru Stan
2020-10-14 11:26 ` Daniel Thompson
2020-10-15 6:54 ` Geert Uytterhoeven [this message]
2020-10-22 3:51 ` Alexandru Stan
2020-10-13 8:01 ` [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels Alexandru Stan
2020-10-14 14:19 ` Daniel Thompson
2020-10-15 21:29 ` Alexandru M Stan
2020-10-13 8:01 ` [PATCH v2 3/3] arm64: dts: qcom: trogdor: Add brightness-levels Alexandru Stan
2020-10-13 16:28 ` Doug Anderson
2020-10-14 11:33 ` Daniel Thompson
2020-10-14 13:51 ` Doug Anderson
2020-10-15 9:15 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdUSWWSVQCxX-rv3MCvw59q+dscQ3bC4yysVCPyxdaEi6w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=agross@kernel.org \
--cc=amstan@chromium.org \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=heiko@sntech.de \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).