From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Tuowen Zhao <ztuowen@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
acelan.kao@canonical.com, "Luis R. Rodriguez" <mcgrof@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
kbuild test robot <lkp@intel.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v5 1/4] sparc64: implement ioremap_uc
Date: Tue, 10 Dec 2019 09:08:42 +0100 [thread overview]
Message-ID: <CAMuHMdUsKQPvOwxARcWMqmFB7BdatZe=3bR+BG=DCaq_yMfySw@mail.gmail.com> (raw)
In-Reply-To: <20191016210629.1005086-2-ztuowen@gmail.com>
On Thu, Oct 17, 2019 at 7:47 PM Tuowen Zhao <ztuowen@gmail.com> wrote:
> On sparc64, the whole physical IO address space is accessible using
> physically addressed loads and stores. *_uc does nothing like the
> others.
>
> Cc: <stable@vger.kernel.org>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Tuowen Zhao <ztuowen@gmail.com>
> ---
> arch/sparc/include/asm/io_64.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sparc/include/asm/io_64.h b/arch/sparc/include/asm/io_64.h
> index 688911051b44..f4afa301954a 100644
> --- a/arch/sparc/include/asm/io_64.h
> +++ b/arch/sparc/include/asm/io_64.h
> @@ -407,6 +407,7 @@ static inline void __iomem *ioremap(unsigned long offset, unsigned long size)
> }
>
> #define ioremap_nocache(X,Y) ioremap((X),(Y))
> +#define ioremap_uc(X,Y) ioremap((X),(Y))
> #define ioremap_wc(X,Y) ioremap((X),(Y))
> #define ioremap_wt(X,Y) ioremap((X),(Y))
Do we really need this? There is only one user of ioremap_uc(), which
Christoph is trying hard to get rid of, and the new devres helper that
triggers all of this :-(
https://lore.kernel.org/dri-devel/20191112105507.GA7122@lst.de/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-12-10 8:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 21:06 [PATCH v5 0/4] Fix MTRR bug for intel-lpss-pci Tuowen Zhao
2019-10-16 21:06 ` [PATCH v5 1/4] sparc64: implement ioremap_uc Tuowen Zhao
2019-10-16 21:20 ` David Miller
2019-10-28 20:46 ` Fwd: " Tuowen Zhao
2019-10-28 23:09 ` David Miller
2019-11-11 8:40 ` Fwd: " Lee Jones
2019-12-10 8:08 ` Geert Uytterhoeven [this message]
2019-10-16 21:06 ` [PATCH v5 2/4] lib: devres: add a helper function for ioremap_uc Tuowen Zhao
[not found] ` <20191017143144.9985421848@mail.kernel.org>
2019-10-17 17:49 ` Tuowen Zhao
2019-10-18 16:47 ` Sasha Levin
2019-12-04 15:51 ` Tuowen Zhao
2019-12-04 19:54 ` Andy Shevchenko
2019-12-04 20:06 ` Tuowen Zhao
2019-12-16 13:06 ` Greg KH
2019-12-16 18:02 ` Tuowen Zhao
2019-11-11 8:41 ` Lee Jones
2019-12-10 8:06 ` Geert Uytterhoeven
2019-12-10 12:50 ` Lee Jones
2019-10-16 21:06 ` [PATCH v5 3/4] mfd: intel-lpss: use devm_ioremap_uc for MMIO Tuowen Zhao
2019-10-22 19:01 ` Roman Gilg
2019-11-11 8:41 ` Lee Jones
2019-12-10 8:11 ` Geert Uytterhoeven
2019-10-16 21:06 ` [PATCH v5 4/4] docs: driver-model: add devm_ioremap_uc Tuowen Zhao
2019-10-23 11:26 ` Luis Chamberlain
2019-11-11 8:41 ` Lee Jones
2019-10-17 7:14 ` [PATCH v5 0/4] Fix MTRR bug for intel-lpss-pci Andy Shevchenko
2019-10-17 7:31 ` Lee Jones
2019-10-17 8:04 ` Andy Shevchenko
2019-10-17 8:22 ` Lee Jones
2019-10-17 9:52 ` Andy Shevchenko
2019-11-11 8:43 ` [GIT PULL] Immutable branch between MFD, Docs, Sparc and Lib Devres due for the v5.5 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdUsKQPvOwxARcWMqmFB7BdatZe=3bR+BG=DCaq_yMfySw@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=acelan.kao@canonical.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mcgrof@kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ztuowen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).