From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83F9CC433F5 for ; Wed, 27 Apr 2022 15:16:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239568AbiD0PTY convert rfc822-to-8bit (ORCPT ); Wed, 27 Apr 2022 11:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239531AbiD0PSp (ORCPT ); Wed, 27 Apr 2022 11:18:45 -0400 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B30E5839E; Wed, 27 Apr 2022 08:15:29 -0700 (PDT) Received: by mail-qv1-f50.google.com with SMTP id kc16so352647qvb.7; Wed, 27 Apr 2022 08:15:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7+G8Cf9crq/FmkHAa1hmIN8g6GY3mjT1aMgwO4UslU4=; b=b0OW7JAkegRE3wuNJmjgUNjmYa2T/JOjrT9Es9/UJaOFRkSjzVJVy3FIl8zNDWwTpm rUDcvQohwfebUgaj4QXQCZQS+ttDU5ppMLed/h+2mAj8bm03/daj4rgnvL99S5J2oumT vfmzhOP7Rr8L5LXJEgizeatZwQatn9qUwZ/fmKaQX86/7/LTuLoebJuYv9GdWQAETiC2 i3jaZxgsUQWxDgdOtAV5JaMqZAVsX8sjjL07nfg1gnt8ij/5vn+C/GDDzhiLnCZBcRAS U3evsAP+JHTM7+WVRAQaOurFcT4jf6QMSXChZ0Jbsw5JuLkWyJgh4gi2xilqvihnFvaB 7r7Q== X-Gm-Message-State: AOAM530CRuJzMO1K+YNbs0SuCV0sCb9NZarAfdk6TbdWZf0I0WehIyb3 H+x7iv94FR4vCQ9GCUWIRWbaA3cywhB9pQ== X-Google-Smtp-Source: ABdhPJwejfgEkKFhJu6j1wrVsqZANMB8i6Kt9hkHG9474jg0usCHPWjYuZWKGELEiSA3LcqVssHKMQ== X-Received: by 2002:a05:6214:252b:b0:456:3c2b:c910 with SMTP id gg11-20020a056214252b00b004563c2bc910mr9361804qvb.85.1651072528222; Wed, 27 Apr 2022 08:15:28 -0700 (PDT) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id m190-20020a378ac7000000b0069f8d810f16sm890605qkd.85.2022.04.27.08.15.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 08:15:27 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id e12so3920309ybc.11; Wed, 27 Apr 2022 08:15:27 -0700 (PDT) X-Received: by 2002:a25:9e89:0:b0:63c:ad37:a5de with SMTP id p9-20020a259e89000000b0063cad37a5demr26199241ybq.342.1651072527257; Wed, 27 Apr 2022 08:15:27 -0700 (PDT) MIME-Version: 1.0 References: <20220422120850.769480-1-herve.codina@bootlin.com> <20220422120850.769480-3-herve.codina@bootlin.com> In-Reply-To: <20220422120850.769480-3-herve.codina@bootlin.com> From: Geert Uytterhoeven Date: Wed, 27 Apr 2022 17:15:15 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/8] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 To: Herve Codina Cc: Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Rob Herring , Krzysztof Kozlowski , Magnus Damm , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hervé, On Fri, Apr 22, 2022 at 2:09 PM Herve Codina wrote: > Add internal PCI bridge support for the r9a06g032 SOC. The Renesas > RZ/N1D (R9A06G032) internal PCI bridge is compatible with the one > present in the R-Car Gen2 family. > Compared to the R-Car Gen2 family, it needs three clocks instead of > one. > > Signed-off-by: Herve Codina Thanks for your patch! > --- a/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml > +++ b/Documentation/devicetree/bindings/pci/renesas,pci-rcar-gen2.yaml > @@ -113,6 +113,37 @@ required: > - "#size-cells" > - "#interrupt-cells" > > +if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,pci-rzn1 > + > +then: > + properties: > + clocks: > + items: > + - description: Internal bus clock (AHB) for HOST > + - description: Internal bus clock (AHB) Power Management > + - description: PCI clock for USB subsystem > + clock-names: > + items: > + - const: hclk_usbh > + - const: hclk_usbpm > + - const: clk_pci_usb These are the provider names. I think they should use the consumer names: usb_hclkh, usb_hclkpm, and usb_pciclk. The rest looks good to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds