From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Prabhakar <prabhakar.csengg@gmail.com>
Subject: Re: [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller
Date: Thu, 3 Sep 2020 12:18:45 +0200 [thread overview]
Message-ID: <CAMuHMdVVvDEq-GSsPDrx09TCfGCWkNQvGYrNWP4gK2=63G2z1w@mail.gmail.com> (raw)
In-Reply-To: <20200825162718.5838-2-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar,
On Tue, Aug 25, 2020 at 6:28 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> Enable PCIe Controller and set PCIe bus clock frequency.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.10.
One thing to double-check below.
> --- a/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> +++ b/arch/arm/boot/dts/r8a7742-iwg21d-q7.dts
> @@ -238,6 +238,18 @@
> /* status = "okay"; */
> };
>
> +&pcie_bus_clk {
> + clock-frequency = <100000000>;
> +};
> +
> +&pciec {
> + /* SW2[6] determines which connector is activated
> + * ON = PCIe X4 (connector-J7)
> + * OFF = mini-PCIe (connector-J26)
The table on page 14 says it's the other way around.
According to the CBTL02042ABQ datasheet, PCIe_SEL = low
selects the first channel (PCIe x4), while PCIe_SEL = high selects the
second channel (mini-PCIe).
Enabling the switch ties the signal low, so the table must be wrong.
> + */
> + status = "okay";
> +};
> +
> &pfc {
> avb_pins: avb {
> groups = "avb_mdio", "avb_gmii";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2020-09-03 10:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 16:27 [PATCH 0/4] iWave G21D-Q7 enable PCIe, flash, CAN and SD2 LED Lad Prabhakar
2020-08-25 16:27 ` [PATCH 1/4] ARM: dts: r8a7742-iwg21d-q7: Enable PCIe Controller Lad Prabhakar
2020-09-03 10:18 ` Geert Uytterhoeven [this message]
2020-09-03 11:18 ` Lad, Prabhakar
2020-09-03 11:29 ` Geert Uytterhoeven
2020-10-09 7:23 ` Pavel Machek
2020-10-09 9:01 ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 2/4] ARM: dts: r8a7742-iwg21d-q7: Add SPI NOR support Lad Prabhakar
2020-09-03 11:59 ` Geert Uytterhoeven
2020-09-04 17:24 ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 3/4] ARM: dts: r8a7742-iwg21d-q7: Add can0 support to carrier board Lad Prabhakar
2020-09-03 12:14 ` Geert Uytterhoeven
2020-09-04 17:17 ` Lad, Prabhakar
2020-08-25 16:27 ` [PATCH 4/4] ARM: dts: r8a7742-iwg21d-q7: Enable SD2 LED indication Lad Prabhakar
2020-09-03 12:20 ` Geert Uytterhoeven
2020-09-04 17:15 ` Lad, Prabhakar
2020-09-07 7:55 ` Geert Uytterhoeven
2020-09-07 15:23 ` Lad, Prabhakar
2020-10-09 7:26 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVVvDEq-GSsPDrx09TCfGCWkNQvGYrNWP4gK2=63G2z1w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).