From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up"
Date: Fri, 13 Jul 2018 22:08:28 +0200 [thread overview]
Message-ID: <CAMuHMdVdd1o51X-DwntSjxcMBjA30Unnorv4_A=5TXYFh6_n1w@mail.gmail.com> (raw)
In-Reply-To: <20180713154720.18316-2-geert+renesas@glider.be>
On Fri, Jul 13, 2018 at 6:31 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Currently the BD9571MWV PMIC driver uses the standard "wake_up" sysfs
> file to control enablement of DDR Backup Mode.
>
> However, configuring DDR Backup Mode is not really equivalent to
> configuring the PMIC as a wake-up source. To avoid confusion, use a
> custom "backup_mode" attribute file in sysfs instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
> - New.
> ---
> drivers/regulator/bd9571mwv-regulator.c | 52 ++++++++++++++++++++++---
> 1 file changed, 46 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/bd9571mwv-regulator.c b/drivers/regulator/bd9571mwv-regulator.c
> index be574eb444ebda97..7432b605db4dc879 100644
> --- a/drivers/regulator/bd9571mwv-regulator.c
> +++ b/drivers/regulator/bd9571mwv-regulator.c
> @@ -270,15 +298,26 @@ static int bd9571mwv_regulator_probe(struct platform_device *pdev)
> return -EINVAL;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> if (bdreg->bkup_mode_cnt_keepon) {
> - device_set_wakeup_capable(&pdev->dev, true);
> /*
> - * Wakeup is enabled by default in pulse mode, but needs
> + * Backup mode is enabled by default in pulse mode, but needs
> * explicit user setup in level mode.
> */
> - device_set_wakeup_enable(&pdev->dev, bdreg->rstbmode_pulse);
> + bdreg->bkup_mode_enabled = bdreg->rstbmode_pulse;
> +
> + ret = device_create_file(&pdev->dev, &dev_attr_backup_mode);
> + if (ret)
> + return ret;
> }
> +#endif /* CONFIG_PM_SLEEP */
> +
> + return 0;
> +}
>
> +static int bd9571mwv_regulator_remove(struct platform_device *pdev)
> +{
> + device_remove_file(&pdev->dev, &dev_attr_backup_mode);
Woops, this line needs to be protected by CONFIG_PM_SLEEP.
Thank you, 0-day!
> return 0;
> }
>
> @@ -294,6 +333,7 @@ static struct platform_driver bd9571mwv_regulator_driver = {
> .pm = DEV_PM_OPS,
> },
> .probe = bd9571mwv_regulator_probe,
> + .remove = bd9571mwv_regulator_remove,
> .id_table = bd9571mwv_regulator_id_table,
> };
> module_platform_driver(bd9571mwv_regulator_driver);
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-07-13 20:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 15:47 [PATCH v3 0/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-13 15:47 ` [PATCH v3 1/3] regulator: bd9571mwv: Use "backup_mode" sysfs file instead of "wake_up" Geert Uytterhoeven
2018-07-13 20:08 ` Geert Uytterhoeven [this message]
2018-07-13 15:47 ` [PATCH v3 2/3] regulator: bd9571mwv: Add support for toggle power switches Geert Uytterhoeven
2018-07-13 15:47 ` [PATCH v3 3/3] regulator: bd9571mwv: Document "backup_mode" sysfs file Geert Uytterhoeven
2018-07-15 16:59 ` Pavel Machek
2018-07-15 16:57 ` [PATCH v3 0/3] regulator: bd9571mwv: Add support for toggle power switches Pavel Machek
2018-07-16 8:58 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVdd1o51X-DwntSjxcMBjA30Unnorv4_A=5TXYFh6_n1w@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=len.brown@intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).