From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Amit Pundir" <amit.pundir@linaro.org>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-m68k <linux-m68k@lists.linux-m68k.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Martijn Coenen" <maco@google.com>,
"John Stultz" <john.stultz@linaro.org>,
kbuild-all@01.org, Linux-Arch <linux-arch@vger.kernel.org>,
"Martijn Coenen" <maco@android.com>,
"Todd Kjos" <tkjos@google.com>
Subject: Re: [PATCH] ANDROID: binder: remove 32-bit binder interface.
Date: Mon, 14 May 2018 16:00:19 +0200 [thread overview]
Message-ID: <CAMuHMdW0nxOmq7gjJiySg0fho2XDYkyrCgp88OOuULRLH+jt6w@mail.gmail.com> (raw)
In-Reply-To: <20180514120338.GA5265@infradead.org>
Hi Christoph,
On Mon, May 14, 2018 at 2:03 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Fri, May 11, 2018 at 09:57:52AM +0200, Martijn Coenen wrote:
>> On Sat, May 5, 2018 at 2:10 PM, kbuild test robot <lkp@intel.com> wrote:
>> > drivers/android/binder.o: In function `binder_thread_write':
>> >>> binder.c:(.text+0x6a16): undefined reference to `__get_user_bad'
>>
>> Looks like m68k doesn't support 64-bit get_user(). I could just have
>> binder depend on !CONFIG_M68K, but there may be other architectures
>> still that don't support this. Another alternative would be to
>> whitelist the architectures Android supports - eg arm, arm64, x86,
>> x86_64. But I'm not sure if arch-limited drivers are considered bad
>> form. Does anybody have suggestions for how to deal with this?
>
> The proper fix is to just support 640bit get/put_user on m68k instead
I hope we'll never need 640bit support in {get,put}_user() ;-)
> of working around this.
Patch sent.
BTW, sh also doesn't seem to have 64-bit get_user().
There may be others.
BTW2, does the Android Binder need to care about endianness when talking
to userspace?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-05-14 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 19:57 [PATCH] ANDROID: binder: remove 32-bit binder interface Martijn Coenen
2018-05-05 21:10 ` kbuild test robot
2018-05-11 7:57 ` Martijn Coenen
2018-05-11 8:08 ` Greg KH
2018-05-11 8:17 ` Martijn Coenen
2018-05-14 12:03 ` Christoph Hellwig
2018-05-14 14:00 ` Geert Uytterhoeven [this message]
2018-05-14 21:30 ` Martijn Coenen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW0nxOmq7gjJiySg0fho2XDYkyrCgp88OOuULRLH+jt6w@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=amit.pundir@linaro.org \
--cc=arnd@arndb.de \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=john.stultz@linaro.org \
--cc=kbuild-all@01.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=maco@android.com \
--cc=maco@google.com \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).