From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753717AbcEYIsl (ORCPT ); Wed, 25 May 2016 04:48:41 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33047 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753247AbcEYIsg (ORCPT ); Wed, 25 May 2016 04:48:36 -0400 MIME-Version: 1.0 In-Reply-To: <20160525082401.7249.qmail@ns.sciencehorizons.net> References: <20160525082401.7249.qmail@ns.sciencehorizons.net> Date: Wed, 25 May 2016 10:48:34 +0200 X-Google-Sender-Auth: s12TMk0x1Eo_LIc9hcDW2aXFmrY Message-ID: Subject: Re: [PATCH 08v2/10] m68k: Add From: Geert Uytterhoeven To: George Spelvin Cc: Greg Ungerer , "linux-kernel@vger.kernel.org" , linux-m68k , Thomas Gleixner , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 25, 2016 at 10:24 AM, George Spelvin wrote: > --- a/arch/m68k/Kconfig.cpu > +++ b/arch/m68k/Kconfig.cpu > @@ -40,6 +40,7 @@ config M68000 > select CPU_HAS_NO_MULDIV64 > select CPU_HAS_NO_UNALIGNED > select GENERIC_CSUM > + select HAVE_ARCH_HASH > help > The Freescale (was Motorola) 68000 CPU is the first generation of > the well known M68K family of processors. The CPU core as well as > diff --git a/arch/m68k/include/asm/archhash.h b/arch/m68k/include/asm/archhash.h > new file mode 100644 > index 00000000..2532cf92 > --- /dev/null > +++ b/arch/m68k/include/asm/archhash.h > @@ -0,0 +1,58 @@ > +#ifndef _ASM_ARCHHASH_H > +#define _ASM_ARCHHASH_H > + > +/* > + * The only 68k processors that lack MULU.L and so need this workaround > + * are the original 68000 and 68010. > + */ > +#if defined(CONFIG_M68000) || defined(CONFIG_M68010) As I said before, I don't think you need this check, given HAVE_ARCH_HASH is selected by M68000, and M68010 doesn't exist. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds