From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Rob Herring <robh@kernel.org>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
MTD Maling List <linux-mtd@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH] dt-bindings: mtd: spi-nor: Convert to DT schema format
Date: Tue, 16 Feb 2021 10:12:59 +0100 [thread overview]
Message-ID: <CAMuHMdWyTWqF=2fwAmkedMCrZ_owF9nhmGWYf6Xe=CRuOB1ZEQ@mail.gmail.com> (raw)
In-Reply-To: <20210202175340.3902494-1-robh@kernel.org>
Hi Rob,
On Tue, Feb 2, 2021 at 6:54 PM Rob Herring <robh@kernel.org> wrote:
> Convert the SPI-NOR binding to DT schema format. Like other memory chips,
> the compatible strings are a mess with vendor prefixes not being used
> consistently and some compatibles not documented. The resulting schema
> passes on 'compatible' checks for most in tree users with the exception
> of some oddballs.
>
> I dropped the 'm25p.*-nonjedec' compatible strings as these don't appear
> to be used anywhere.
>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Vignesh Raghavendra <vigneshr@ti.com>
> Cc: linux-mtd@lists.infradead.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Thanks for your patch!
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
> @@ -0,0 +1,102 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mtd/jedec,spi-nor.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: SPI NOR flash ST M25Pxx (and similar) serial flash chips
> +
> +maintainers:
> + - Rob Herring <robh@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - pattern: "^((((micron|spansion|st),)?\
> + (m25p(40|80|16|32|64|128)|\
> + n25q(32b|064|128a11|128a13|256a|512a|164k)))|\
> + atmel,at25df(321a|641|081a)|\
> + everspin,mr25h(10|40|128|256)|\
> + (mxicy|macronix),mx25l(4005a|1606e|6405d|8005|12805d|25635e)|\
> + (mxicy|macronix),mx25u(4033|4035)|\
> + (spansion,)?s25fl(128s|256s1|512s|008k|064k|164k)|\
> + (sst|microchip),sst25vf(016b|032b|040b)|\
> + (sst,)?sst26wf016b|\
> + (sst,)?sst25wf(040b|080)|\
> + winbond,w25x(80|32)|\
> + (winbond,)?w25q(16|32(w|dw)?|64(dw)?|80bl|128(fw)?|256))$"
> + - const: jedec,spi-nor
> + - items:
> + - enum:
> + - issi,is25lp016d
> + - micron,mt25qu02g
> + - mxicy,mx25r1635f
> + - mxicy,mx25u6435f
> + - mxicy,mx25v8035f
> + - spansion,s25sl12801
> + - spansion,s25fs512s
> + - const: jedec,spi-nor
> + - const: jedec,spi-nor
> + description:
> + Must also include "jedec,spi-nor" for any SPI NOR flash that can be
> + identified by the JEDEC READ ID opcode (0x9F).
Is there any value in keeping this paragraph?
The schema already requires "jedec,spi-nor".
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2021-02-16 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 17:53 [PATCH] dt-bindings: mtd: spi-nor: Convert to DT schema format Rob Herring
2021-02-09 21:23 ` Rob Herring
2021-02-16 9:12 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdWyTWqF=2fwAmkedMCrZ_owF9nhmGWYf6Xe=CRuOB1ZEQ@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).