From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Chuhong Yuan <hslester96@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state
Date: Thu, 7 Nov 2019 09:30:36 +0100 [thread overview]
Message-ID: <CAMuHMdXSKU40E8Br0Z53H2FyrQsLxnB-EERZoN6HQHExP5tqxQ@mail.gmail.com> (raw)
In-Reply-To: <20191031221211.GA3853@kunai>
Hi Wolfram,
On Thu, Oct 31, 2019 at 11:58 PM Wolfram Sang <wsa@the-dreams.de> wrote:
> > > Well, I don't like to bail out because this error is not fatal for basic
> > > operations. How about releasing priv->pinctrl again with an additional
> > > warning that pinctrl settings are broken and will prevent 1.8v modes?
> > >
> > > Opinions?
> >
> > Hmm, from a mmc driver probe point of view, I don't quite share this approach.
> >
> > I would rather fail as it forces the DTB to be corrected immediately,
> > rather than trusting some developer to look at a warning in a log. The
> > point is, in such a case it may never get fixed, if the product is
> > shipped with the wrong DTB.
>
> I could agree to this arguement, iff the only way pinctrl_select fails
> is a DT misconfiguration. I am not sure if this is true right now, and
> we can't be sure about the future. Or?
Isn't "state_uhs" optional? So bailing out if it doesn't exist is wrong.
"default" should be there, if the device node has pinctrl properties.
renesas_sdhi_start_signal_voltage_switch() already handles fallback
to 3v3 operation.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2019-11-07 8:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:13 [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state Chuhong Yuan
2019-10-21 14:32 ` Ulf Hansson
2019-10-21 20:10 ` Wolfram Sang
2019-10-23 15:33 ` Wolfram Sang
2019-10-30 15:09 ` Ulf Hansson
2019-10-31 22:12 ` Wolfram Sang
2019-11-07 8:30 ` Geert Uytterhoeven [this message]
2019-11-24 3:20 ` Chuhong Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXSKU40E8Br0Z53H2FyrQsLxnB-EERZoN6HQHExP5tqxQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=hslester96@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).