From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Stephan Mueller <smueller@chronox.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: cryptomgr_test / drbg_ctr: BUG: sleeping function called from invalid context
Date: Tue, 26 Jun 2018 12:33:48 +0200 [thread overview]
Message-ID: <CAMuHMdXfn6YuG9imLKd5nEdxhT4gWu-V8bn1LRt+M3bESaUAkA@mail.gmail.com> (raw)
In-Reply-To: <14009987.cibGRJrWdm@positron.chronox.de>
Hi Stephan,
On Sun, May 20, 2018 at 9:54 PM Stephan Müller <smueller@chronox.de> wrote:
> Am Freitag, 18. Mai 2018, 10:36:04 CEST schrieb Geert Uytterhoeven:
> > I tried following the code path, but couldn't find where it went wrong.
> >
> > mutex_lock(&drbg->drbg_mutex) is called from drbg_instantiate(), which is
> > inlined by the compiler into drbg_kcapi_seed().
> >
> > Do you have a clue?
>
> It is the first time I hear from such an issue. Yes, the DRBG should not be
> called in atomic context. But I do not see where we have an atomic context
> (either a spin_lock or in an interrupt handler) when we are executing the test
> manager.
>
> I will keep looking.
Issue is gone. I assume due to commit 6e88f01206edab0e ("crypto: arm64/aes-blk
- fix and move skcipher_walk_done out of kernel_neon_begin, _end").
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-06-26 10:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 8:36 cryptomgr_test / drbg_ctr: BUG: sleeping function called from invalid context Geert Uytterhoeven
2018-05-20 19:54 ` Stephan Müller
2018-06-26 10:33 ` Geert Uytterhoeven [this message]
2018-06-26 11:33 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXfn6YuG9imLKd5nEdxhT4gWu-V8bn1LRt+M3bESaUAkA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).