From: Ricardo Ribalda <ribalda@chromium.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-media@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
tfiga@chromium.org
Subject: Re: [PATCH 0/4] Follow-up patches for uvc v4l2-compliance
Date: Fri, 12 Nov 2021 11:09:14 +0100 [thread overview]
Message-ID: <CANiDSCsDWz5rS881NXXcuxJYb5RP=HLEmdQaYiKrjqyvhO223A@mail.gmail.com> (raw)
In-Reply-To: <CADvTj4r_SzChXj04Ddn6PPUDN7QnKczm6MJXeES-uUUQx3ds+Q@mail.gmail.com>
Hi James
>Pixel Format : 'MJPG' (Motion-JPEG)
>Field : None
>Bytes per Line : 0
>Size Image : 614400
>Colorspace : Default
>ioctl(3, VIDIOC_G_FMT, {type=0 /* V4L2_BUF_TYPE_??? */}) = -1 EINVAL
>(Invalid argument)
>ioctl(3, VIDIOC_G_FMT, {type=V4L2_BUF_TYPE_VIDEO_CAPTURE,
>fmt.pix={width=640, height=480, pixelformat=v4l2_fourcc('M', 'J', 'P',
>'G') /* V4L2_PIX_FMT_MJPEG */, field=V4L2_FIELD_NONE, bytesperline=0,
>sizeimage=614400, colorspace=V4L2_COLORSPACE_DEFAULT}}) = 0
>write(1, "\t\t\33[1;31mfail\33[0m: v4l2-test-for"..., 59 fail:
>v4l2-test-formats.cpp(358): !colorspace
>) = 59
Thanks for testing it out. In this case I believe that it is a camera
bug. The error is due to the fact that the colorspace is does not have
a valid value. That value is provided by the camera:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/media/usb/uvc/uvc_driver.c#n766
You might have to send a patch with a quirk for your device.
next prev parent reply other threads:[~2021-11-12 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:00 [PATCH 0/4] Follow-up patches for uvc v4l2-compliance Ricardo Ribalda
2021-09-09 15:00 ` [PATCH 1/4] media: uvcvideo: uvc_ctrl_is_accessible: check for INACTIVE Ricardo Ribalda
2021-09-09 15:00 ` [PATCH 2/4] media: uvcvideo: improve error logging in uvc_query_ctrl() Ricardo Ribalda
2021-09-09 15:00 ` [PATCH 3/4] media: uvcvideo: Return -EACCES for Wrong state error Ricardo Ribalda
2021-09-09 15:00 ` [PATCH 4/4] media: uvcvideo: Do not return positive errors in uvc_query_ctrl() Ricardo Ribalda
2021-11-11 20:41 ` [PATCH 0/4] Follow-up patches for uvc v4l2-compliance James Hilliard
2021-11-11 20:52 ` Ricardo Ribalda
2021-11-11 21:22 ` James Hilliard
2021-11-11 21:27 ` Ricardo Ribalda
2021-11-11 22:04 ` James Hilliard
2021-11-12 10:09 ` Ricardo Ribalda [this message]
2021-11-12 10:45 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiDSCsDWz5rS881NXXcuxJYb5RP=HLEmdQaYiKrjqyvhO223A@mail.gmail.com' \
--to=ribalda@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=james.hilliard1@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).