linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: "Måns Rullgård" <mans@mansr.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Robert Abel <rabel@robertabel.eu>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Willy Tarreau <w@1wt.eu>,
	Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH] auxdisplay: charlcd: fix x/y command parsing
Date: Thu, 6 Dec 2018 11:06:22 +0100	[thread overview]
Message-ID: <CANiq72keqco3F=8YDHFqoeBRFsrs1Cbd1aF1owf90Hbncv40mA@mail.gmail.com> (raw)
In-Reply-To: <yw1xr2evkg8t.fsf@mansr.com>

On Wed, Dec 5, 2018 at 6:58 PM Måns Rullgård <mans@mansr.com> wrote:
>
> Suppose the command "\e[Lx0y0;" is written to the device.  The
> charlcd_write_char() function adds one character at a time to the escape
> sequence buffer.

Ah, yes, that is much more clear. Indeed, parse_xy() expects the
entire command; the strchr() should still be there.

By the way, if we are going to move to a direct check, I would also do
so in the generator command too if possible, to be consistent (in
another patch, possibly).

> BTW, the parsing of this command has been broken since 3.2-rc1 due to
> commit 129957069e6a.

Thanks for checking! Are you able to test this?

Cheers,
Miguel

  reply	other threads:[~2018-12-06 10:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 13:52 [PATCH] auxdisplay: charlcd: fix x/y command parsing Mans Rullgard
2018-12-05 16:47 ` Miguel Ojeda
2018-12-05 17:58   ` Måns Rullgård
2018-12-06 10:06     ` Miguel Ojeda [this message]
2018-12-06 12:06       ` Måns Rullgård
2018-12-13 21:03         ` Miguel Ojeda
2018-12-14 12:15           ` Måns Rullgård
2018-12-14 15:50             ` Miguel Ojeda
2018-12-06 23:13       ` Robert Abel
2018-12-06 23:18         ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72keqco3F=8YDHFqoeBRFsrs1Cbd1aF1owf90Hbncv40mA@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=rabel@robertabel.eu \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).