linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	Will Deacon <will@kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
	"David S. Miller" <davem@davemloft.net>,
	Paul Burton <paul.burton@mips.com>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] compiler-attributes for v5.3-rc8
Date: Thu, 5 Sep 2019 21:40:50 +0200	[thread overview]
Message-ID: <CANiq72mXLbaefVBqZzz1vSREi0=HiBUgR1KU3iRjOCum7rvfrw@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wi2VOPoweqnDhxXKJ9fcLQzkV1oEDjteV=z-C7KXrpomg@mail.gmail.com>

On Thu, Sep 5, 2019 at 6:20 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> Macro stringification isn't entirely obvious, and an unquoted string
> could become corrupted if the stringification ends up not happening
> immediately.

Nick, Linus: shouldn't we just simply go for no stringifying at all,
i.e. changing it to:

    #define __section(S)   __attribute__((__section__(S)))

That way we can handle both easy things like:

    __section("foo")

as well as the mentioned:

    __section(".initcall" level ".init")

that we couldn't do before.

Both GCC and Clang give the same result and it is also easier to
reason about it.

Cheers,
Miguel

  parent reply	other threads:[~2019-09-05 19:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 18:18 [GIT PULL] compiler-attributes for v5.3-rc8 Miguel Ojeda
2019-09-05  6:23 ` Miguel Ojeda
2019-09-05 16:20 ` Linus Torvalds
2019-09-05 17:18   ` Nick Desaulniers
2019-09-05 17:22     ` Linus Torvalds
2019-09-05 19:53       ` Miguel Ojeda
2019-09-05 19:40   ` Miguel Ojeda [this message]
2019-09-05 20:53     ` Linus Torvalds
2019-09-06 20:11       ` Miguel Ojeda
2019-09-06 22:47         ` Nick Desaulniers
2019-09-06 23:11           ` Linus Torvalds
2019-09-07  0:06             ` Nick Desaulniers
2019-09-07  0:08               ` Linus Torvalds
2019-09-07  0:45                 ` Nick Desaulniers
2019-09-07  0:58                   ` Linus Torvalds
2019-09-07  7:52                     ` Sedat Dilek
2019-09-07 11:59                       ` Miguel Ojeda
2019-09-10  8:58                         ` Sedat Dilek
2019-09-10  9:16                           ` Miguel Ojeda
2019-09-08 13:19 Miguel Ojeda
2019-09-08 13:24 ` Miguel Ojeda
2019-09-08 17:25 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANiq72mXLbaefVBqZzz1vSREi0=HiBUgR1KU3iRjOCum7rvfrw@mail.gmail.com' \
    --to=miguel.ojeda.sandonis@gmail.com \
    --cc=davem@davemloft.net \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    --cc=ndesaulniers@google.com \
    --cc=paul.burton@mips.com \
    --cc=sedat.dilek@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).