From: Eric Dumazet <edumazet@google.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
shaoyafang@didichuxing.com
Subject: Re: [PATCH net-next 2/2] tcp: refactor tcp_queue_rcv
Date: Wed, 11 Jul 2018 07:56:59 -0700 [thread overview]
Message-ID: <CANn89iLkt+WC36QRKeB7N+DsqCmERnRj5a21+uBjATT7RzyLAA@mail.gmail.com> (raw)
In-Reply-To: <1531315019-3553-2-git-send-email-laoar.shao@gmail.com>
Hi Yafang
On Wed, Jul 11, 2018 at 6:17 AM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> There're are some code similar to tcp_queue_rcv() in tcp_ofo_queue(),
> so refactor tcp_queue_rcv() to make it be used in tcp_ofo_queue().
>
> After this change, skb->sk is set when skb is moved from ofo queue into
> receive queue instead of when queued into ofo queue.
Why would you do that ???
I urge you to test this on hosts connected to the wild Internet :/
next prev parent reply other threads:[~2018-07-11 14:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 13:16 [PATCH net-next 1/2] tcp: remove redundant rcv_nxt update Yafang Shao
2018-07-11 13:16 ` [PATCH net-next 2/2] tcp: refactor tcp_queue_rcv Yafang Shao
2018-07-11 14:56 ` Eric Dumazet [this message]
2018-07-11 17:01 ` [PATCH net-next 1/2] tcp: remove redundant rcv_nxt update Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANn89iLkt+WC36QRKeB7N+DsqCmERnRj5a21+uBjATT7RzyLAA@mail.gmail.com \
--to=edumazet@google.com \
--cc=davem@davemloft.net \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).