From: Magnus Damm <magnus.damm@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
iommu@lists.linux-foundation.org,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Joerg Roedel <joro@8bytes.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org,
Simon Horman <horms+renesas@verge.net.au>
Subject: Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code
Date: Wed, 8 Jun 2016 17:05:30 +0900 [thread overview]
Message-ID: <CANqRtoQ1t=_FK=Ess89N3f4OgUC7j=AhRH2C462mtKeuv-DmHg@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdUr6P=xiiw02wEeJdBw+K_q2ATE9jHgiQ0KCOangYv=tw@mail.gmail.com>
Hi Geert,
On Wed, Jun 8, 2016 at 4:04 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> Hi Laurent,
>
> On Wed, Jun 8, 2016 at 2:18 AM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
>>> --- 0031/drivers/iommu/ipmmu-vmsa.c
>>> +++ work/drivers/iommu/ipmmu-vmsa.c 2016-06-06 11:19:40.210607110 +0900
>>> @@ -1074,7 +1074,7 @@ static const struct ipmmu_features ipmmu
>>> .twobit_imttbcr_sl0 = false,
>>> };
>>>
>>> -static const struct ipmmu_features ipmmu_features_r8a7795 = {
>>> +static const struct ipmmu_features ipmmu_features_rcar_gen3 = {
>>> .use_ns_alias_offset = false,
>>> .has_cache_leaf_nodes = true,
>>> .has_eight_ctx = true,
>>> @@ -1088,7 +1088,10 @@ static const struct of_device_id ipmmu_o
>>> .data = &ipmmu_features_default,
>>> }, {
>>> .compatible = "renesas,ipmmu-r8a7795",
>>> - .data = &ipmmu_features_r8a7795,
>>> + .data = &ipmmu_features_rcar_gen3,
>>> + }, {
>>> + .compatible = "renesas,ipmmu-r8a7796",
>>> + .data = &ipmmu_features_rcar_gen3,
>>> }, {
>>> /* Terminator */
>>> },
>>> @@ -1268,6 +1271,8 @@ IOMMU_OF_DECLARE(ipmmu_vmsa_iommu_of, "r
>>> ipmmu_vmsa_iommu_of_setup);
>>> IOMMU_OF_DECLARE(ipmmu_r8a7795_iommu_of, "renesas,ipmmu-r8a7795",
>>> ipmmu_vmsa_iommu_of_setup);
>>> +IOMMU_OF_DECLARE(ipmmu_r8a7796_iommu_of, "renesas,ipmmu-r8a7796",
>>> + ipmmu_vmsa_iommu_of_setup);
>>
>> How about a Gen3 generic compatible string in addition to the SoC-specific
>> ones ?
>
> Do we want to specify the number of utlbs here?
> Does it differ between r8a7795, r8a7796, and future members?
The utlb number is already a property of the SoC part number. So I
don't see why we want to encode this as a separate DT property instead
of going with an in-driver feature flag.
Thanks,
/ magnus
next prev parent reply other threads:[~2016-06-08 8:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 3:39 [PATCH 0/3] iommu/ipmmu-vmsa: Initial r8a7796 support Magnus Damm
2016-06-07 3:39 ` [PATCH 1/3] iommu/ipmmu-vmsa: Add r8a7796 DT binding Magnus Damm
2016-06-08 0:17 ` Laurent Pinchart
2016-06-07 3:39 ` [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48 Magnus Damm
2016-06-07 10:59 ` Sergei Shtylyov
2016-06-08 0:17 ` Laurent Pinchart
2016-06-07 3:39 ` [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code Magnus Damm
2016-06-08 0:18 ` Laurent Pinchart
2016-06-08 7:04 ` Geert Uytterhoeven
2016-06-08 8:05 ` Magnus Damm [this message]
2016-06-08 8:48 ` Laurent Pinchart
2016-06-08 9:12 ` Magnus Damm
2016-08-09 13:17 ` Laurent Pinchart
2016-08-09 13:19 ` Laurent Pinchart
2016-06-08 8:07 ` Magnus Damm
2016-06-07 7:31 ` [PATCH 0/3] iommu/ipmmu-vmsa: Initial r8a7796 support Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANqRtoQ1t=_FK=Ess89N3f4OgUC7j=AhRH2C462mtKeuv-DmHg@mail.gmail.com' \
--to=magnus.damm@gmail.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).