From: Fabio Estevam <festevam@gmail.com>
To: Richard Zhu <hongxing.zhu@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Mark Brown <broonie@kernel.org>,
lorenzo.pieralisi@arm.com, jingoohan1@gmail.com,
stable@vger.kernel.org, linux-pci@vger.kernel.org,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v5 5/6] PCI: imx6: Fix the regulator dump when link never came up
Date: Wed, 5 Jan 2022 18:51:58 -0300 [thread overview]
Message-ID: <CAOMZO5AqgOOo3+r3yQSsfaNxW9eHXhCi=m+mqR=sf=K6dXA8tw@mail.gmail.com> (raw)
In-Reply-To: <1641368602-20401-6-git-send-email-hongxing.zhu@nxp.com>
Hi Richard,
On Wed, Jan 5, 2022 at 5:12 AM Richard Zhu <hongxing.zhu@nxp.com> wrote:
>
> When PCIe PHY link never came up and vpcie regulator is present, there
> would be following dump when try to put the regulator.
> Add a new host_exit() callback for i.MX PCIe driver to disable this
> regulator and fix this dump when link never came up.
>
> The driver should undo any enables it did itself, and not undo any
> enables that anything else did which means it should never be basing
> decisions on regulator_is_enabled().
>
> To keep usage counter balance of the clocks, powers and so on. Do the
> clock disable in the error handling after host_init too.
>
> imx6q-pcie 33800000.pcie: Phy link never came up
> imx6q-pcie: probe of 33800000.pcie failed with error -110
Shouldn't we ignore the dw_pcie_wait_for_link() error?
At least, this was the intention of 886a9c134755 ("PCI: dwc: Move link
handling into
common code").
> ------------[ cut here ]------------
> WARNING: CPU: 3 PID: 119 at drivers/regulator/core.c:2256 _regulator_put.part.0+0x14c/0x158
> Modules linked in:
My concern is that this issue is still present in 5.15, which is LTS.
You only address this problem in 5/6 and I am not sure if the previous
patches could be applied to stable as they are cleanups.
How can we fix this for 5.15 stable?
Could you make a minimal fix as the first patch of the series and
cleanup patches later?
next prev parent reply other threads:[~2022-01-05 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-05 7:43 [PATCH v5 0/6] PCI: imx6: refine codes and add compliance tests mode support Richard Zhu
2022-01-05 7:43 ` [PATCH v5 1/6] PCI: imx6: Encapsulate the clock enable into one standalone function Richard Zhu
2022-01-05 7:43 ` [PATCH v5 2/6] PCI: imx6: Add the error propagation from host_init Richard Zhu
2022-01-05 7:43 ` [PATCH v5 3/6] PCI: imx6: PCI: imx6: Move imx6_pcie_clk_disable() earlier Richard Zhu
2022-01-05 19:04 ` Bjorn Helgaas
2022-01-06 3:49 ` Hongxing Zhu
2022-01-05 7:43 ` [PATCH v5 4/6] PCI: dwc: Add dw_pcie_host_ops.host_exit() callback Richard Zhu
2022-01-05 7:43 ` [PATCH v5 5/6] PCI: imx6: Fix the regulator dump when link never came up Richard Zhu
2022-01-05 21:51 ` Fabio Estevam [this message]
2022-01-06 3:49 ` Hongxing Zhu
2022-01-06 10:38 ` Fabio Estevam
2022-01-05 7:43 ` [PATCH v5 6/6] PCI: imx6: Add the compliance tests mode support Richard Zhu
2022-01-05 10:15 ` [PATCH v5 0/6] PCI: imx6: refine codes and add " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5AqgOOo3+r3yQSsfaNxW9eHXhCi=m+mqR=sf=K6dXA8tw@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).