linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Atish Patra <atishp@atishpatra.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Atish Patra <atish.patra@wdc.com>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
	linux-efi <linux-efi@vger.kernel.org>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 10/11] efi: Rename arm-init to efi-init common for all arch
Date: Fri, 26 Jun 2020 14:57:33 -0700	[thread overview]
Message-ID: <CAOnJCU+=0Ozz=qfMULsN4-4rq_q4UFYsnkH50Bo5PfzUU45e6g@mail.gmail.com> (raw)
In-Reply-To: <8b71b663-8a68-26f3-c806-a2873a6d8923@gmx.de>

On Thu, Jun 25, 2020 at 8:00 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> On 6/26/20 1:45 AM, Atish Patra wrote:
> > arm-init is responsible for setting up efi runtime and doesn't actually
> > do any ARM specific stuff. RISC-V can use the same source code as it is.
> >
> > Rename it to efi-init so that RISC-V can use it.
> >
> > Signed-off-by: Atish Patra <atish.patra@wdc.com>
> > ---
> >  drivers/firmware/efi/{arm-init.c => efi-init.c} | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename drivers/firmware/efi/{arm-init.c => efi-init.c} (100%)
> >
> > diff --git a/drivers/firmware/efi/arm-init.c b/drivers/firmware/efi/efi-init.c
> > similarity index 100%
> > rename from drivers/firmware/efi/arm-init.c
> > rename to drivers/firmware/efi/efi-init.c
> >
>
> After each patch we should have code that builds. This helps when

Absolutely.

> bisecting. Therefore I would have expected an adjustment of
> drivers/firmware/efi/Makefile in this patch and not in patch 11/11:
>
> -arm-obj-$(CONFIG_EFI)                  := arm-init.o arm-runtime.o
> +arm-obj-$(CONFIG_EFI)                  := efi-init.o arm-runtime.o
>

I think I messed it up while rebasing. My bad. I will fix it in the
next version.

> Best regards
>
> Heinrich
>


-- 
Regards,
Atish

  reply	other threads:[~2020-06-26 21:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 23:45 [RFC PATCH 00/11] Add UEFI support for RISC-V Atish Patra
2020-06-25 23:45 ` [RFC PATCH 01/11] efi: Fix gcc error around __umoddi3 for 32 bit builds Atish Patra
2020-06-26  2:42   ` Heinrich Schuchardt
2020-06-26 21:56     ` Atish Patra
2020-06-26 22:03       ` Ard Biesheuvel
2020-06-27  9:22         ` Ard Biesheuvel
2020-06-29 20:09           ` Atish Patra
2020-07-22 22:48   ` [tip: efi/urgent] efi/libstub: " tip-bot2 for Atish Patra
2020-06-25 23:45 ` [RFC PATCH 02/11] RISC-V: Move DT mapping outof fixmap Atish Patra
2020-06-25 23:45 ` [RFC PATCH 03/11] RISC-V: Setup exception vector early Atish Patra
2020-06-25 23:45 ` [RFC PATCH 04/11] RISC-V: Add early ioremap support Atish Patra
2020-06-25 23:45 ` [RFC PATCH 05/11] RISC-V: Set maximum number of mapped pages correctly Atish Patra
2020-06-25 23:45 ` [RFC PATCH 06/11] riscv: Parse all memory blocks to remove unusable memory Atish Patra
2020-06-25 23:45 ` [RFC PATCH 07/11] include: pe.h: Add RISC-V related PE definition Atish Patra
2020-06-25 23:45 ` [RFC PATCH 08/11] RISC-V: Add PE/COFF header for EFI stub Atish Patra
2020-06-25 23:45 ` [RFC PATCH 09/11] RISC-V: Add EFI stub support Atish Patra
2020-06-25 23:45 ` [RFC PATCH 10/11] efi: Rename arm-init to efi-init common for all arch Atish Patra
2020-06-26  3:00   ` Heinrich Schuchardt
2020-06-26 21:57     ` Atish Patra [this message]
2020-06-25 23:45 ` [RFC PATCH 11/11] RISC-V: Add EFI runtime services Atish Patra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOnJCU+=0Ozz=qfMULsN4-4rq_q4UFYsnkH50Bo5PfzUU45e6g@mail.gmail.com' \
    --to=atishp@atishpatra.org \
    --cc=ardb@kernel.org \
    --cc=atish.patra@wdc.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=masahiroy@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).