From: Philippe De Muyter <philippe.demuyter@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: Suggest using min_t or max_t
Date: Wed, 5 Sep 2012 13:21:50 +0200 [thread overview]
Message-ID: <CAOoYnzLViwqp11Tw1zf0C+qhc+AtzefNLzZEbC2oUPkWPV5zqQ@mail.gmail.com> (raw)
In-Reply-To: <7f59aa30d3af02ae522dc38105e51107e34826f2.1306455946.git.joe@perches.com>
On 5/27/11, Joe Perches <joe@perches.com> wrote:
> A common issue with min() or max() is using a cast on
> one or both of the arguments when using min_t/max_t could
> be better.
>
> Add cast detection to uses of min/max and suggest an
> appropriate use of min_t or max_t instead.
>
> Caveat: This only works for min() or max() on a single line.
> It does not find min() or max() split across multiple lines.
>
> This does find:
> min((u32)foo, bar);
> But it does not find:
> max((unsigned long)foo,
> bar);
>
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> v2: Make $match_balanced_parentheses work in perl 5.8
Has this been applied ?
v3.3 version of checkpatch.pl works for me, but v3.4, v3.5 & v3.6rc2 say:
Nested quantifiers in regex; marked by <-- HERE in m/(\((?:[^\(\)]++
<-- HERE |(?-1))*\))/ at scripts/checkpatch.pl line 340.
and my perl is :
perl --version
This is perl, v5.8.8 built for i586-linux-thread-multi
Philippe
next prev parent reply other threads:[~2012-09-05 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 12:21 [PATCH v3] w1: Add Maxim/Dallas DS2780 Stand-Alone Fuel Gauge IC support Clifton Barnes
2011-05-19 19:03 ` Andrew Morton
2011-05-19 20:21 ` Ryan Mallon
[not found] ` <20110519115859.e11a7ca3.akpm@linux-foundation.org>
[not found] ` <1305909981.4209.33.camel@Joe-Laptop>
[not found] ` <20110520095037.25eadc0a.akpm@linux-foundation.org>
[not found] ` <1305912602.4209.41.camel@Joe-Laptop>
[not found] ` <20110520103529.1ef3917c.akpm@linux-foundation.org>
[not found] ` <1305915161.4209.56.camel@Joe-Laptop>
[not found] ` <20110520113830.3faf5230.akpm@linux-foundation.org>
2011-05-20 20:24 ` [PATCH] checkpatch: Suggest using min_t or max_t Joe Perches
2011-05-24 23:35 ` Andrew Morton
2011-05-25 0:11 ` Joe Perches
2011-05-25 23:53 ` Andrew Morton
2011-05-27 0:35 ` [PATCH v2] " Joe Perches
2012-09-05 11:21 ` Philippe De Muyter [this message]
2012-09-05 17:07 ` Joe Perches
2012-09-06 0:16 ` Philippe De Muyter
2012-09-06 0:35 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOoYnzLViwqp11Tw1zf0C+qhc+AtzefNLzZEbC2oUPkWPV5zqQ@mail.gmail.com \
--to=philippe.demuyter@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).