From: Miklos Szeredi <mszeredi@redhat.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/8] vfs: new d_allocate method
Date: Wed, 22 Jun 2016 22:33:12 +0200 [thread overview]
Message-ID: <CAOssrKeCxcOxx4H1z6m8p7AD+cgt9nd30aCUns3U4vOx41skYg@mail.gmail.com> (raw)
In-Reply-To: <20160622170257.GS14480@ZenIV.linux.org.uk>
On Wed, Jun 22, 2016 at 7:02 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Jun 22, 2016 at 04:35:03PM +0200, Miklos Szeredi wrote:
>> Allow filesystem to initialize dentry (->d_fsdata to be explicit) at
>> allocation time.
>
> Something similar had been discussed a while ago (I don't remember whether
> you'd been on Cc, though). E.g. ceph and lustre would benefit from having
> such method (proposed name was ->d_init(), seeing that it's not always
> just an allocation). The subtle part is barriers and I would really like
> to see a proof that you don't need any.
Thanks for the review. Yeah, I missed the rcu concequences. And I
also didn't benchmark anything, it's obviously going to hurt somewhat
for fs that need to alloc an fsdata due to this. I'm waiting to hear
better ideas.
One, rather ugly, is to make the max internal name length fs depenent,
and allow fs to use that space if it wants to trading it for a longer
d_iname.
Thaks,
Miklos
next prev parent reply other threads:[~2016-06-22 20:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 14:35 [PATCH 0/8] remove d_time from dentry Miklos Szeredi
2016-06-22 14:35 ` [PATCH 1/8] vfs: new d_allocate method Miklos Szeredi
2016-06-22 17:02 ` Al Viro
2016-06-22 20:33 ` Miklos Szeredi [this message]
2016-06-22 14:35 ` [PATCH 2/8] ceph: don't use ->d_time Miklos Szeredi
2016-06-23 6:21 ` Yan, Zheng
2016-06-28 8:09 ` Miklos Szeredi
2016-06-28 8:39 ` Yan, Zheng
2016-06-22 14:35 ` [PATCH 3/8] cifs: " Miklos Szeredi
2016-06-22 14:35 ` [PATCH 4/8] vfat: " Miklos Szeredi
2016-06-22 14:35 ` [PATCH 5/8] fuse: " Miklos Szeredi
2016-06-22 16:46 ` Al Viro
2016-06-22 14:35 ` [PATCH 6/8] nfs: " Miklos Szeredi
2016-06-22 16:48 ` Al Viro
2016-06-22 14:35 ` [PATCH 7/8] ncpfs: " Miklos Szeredi
2016-06-22 16:52 ` Al Viro
2016-06-22 14:35 ` [PATCH 8/8] vfs: remove ->d_time Miklos Szeredi
2016-06-22 21:21 ` [PATCH 0/8] remove d_time from dentry Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOssrKeCxcOxx4H1z6m8p7AD+cgt9nd30aCUns3U4vOx41skYg@mail.gmail.com \
--to=mszeredi@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).