From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E9BEC282CC for ; Mon, 28 Jan 2019 04:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0F2D5217D6 for ; Mon, 28 Jan 2019 04:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="JgwM9jlA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbfA1Ei0 (ORCPT ); Sun, 27 Jan 2019 23:38:26 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:45519 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726607AbfA1Ei0 (ORCPT ); Sun, 27 Jan 2019 23:38:26 -0500 Received: by mail-oi1-f196.google.com with SMTP id y1so11956681oie.12 for ; Sun, 27 Jan 2019 20:38:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4o94gMECcDXjEg3sIpRNb9ndtNzEjbC1OgSnKyAQvlI=; b=JgwM9jlA7vZeGN3epEHnd1/PZBv/Wml4B3j2K1N8+m8UzLIkDsEvIjIKWSuIjqfRb9 6ddTRZccL8WQ2tPDd7tBY2BI60u2jQrjgFj3enqqd9Y2nRSpKHBMpun2fOLHhBKLjM9Z 0U4L27D4AhPfQDcDxDRcxYZf9XfBecD0BJzVs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4o94gMECcDXjEg3sIpRNb9ndtNzEjbC1OgSnKyAQvlI=; b=jlOmyw274M0k1cEn6GSibAxI+m6Va52CRQBuZYxI8uTN100Oz4gkN6jvV84KdNazxa 6cxZM26ziTjxOVgOmteACY8akU9Lo4en/xud4b9JuRMND9GMUUBRyeyw5i8oojBHFNVl Cy9uX/iOuDW+iFq+H5ZqqBNTp8XDBz83ZvOPlSqE+Lt0d7+TD2g4GENrIHrMrElpbyuI PaJa9kPCbR9dj4GyA5Y8VzLZ4YTyey7ydH2EPjKMEJNvQ1iWsJMMHjMcCv0pNrgI5IQZ GNipvxAzQE1NSWkZutTfDHbznNrfe2cePYNlINY2oXrK0JLCOyiiu14dlpmJNTxGolwt eAgg== X-Gm-Message-State: AHQUAua6l8tHZlbFUl2VbQgHvRs2WD5jQUFKrz5sKiVk4ZuJse8XgHvu 6HVsAPilxn3x7xXmCUS1rp9bVg40HUM= X-Google-Smtp-Source: ALg8bN5Dpoudh8M0rK/3jq+PQB6m5Uu49yR+dsd4pyMFgGi2rEPW32hJ3npC2E3v0QaDsa79vG7Azg== X-Received: by 2002:aca:2c05:: with SMTP id s5mr5202989ois.190.1548649005314; Sun, 27 Jan 2019 20:16:45 -0800 (PST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com. [209.85.210.54]) by smtp.gmail.com with ESMTPSA id o128sm4488121oif.14.2019.01.27.20.16.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 27 Jan 2019 20:16:44 -0800 (PST) Received: by mail-ot1-f54.google.com with SMTP id e12so13556155otl.5 for ; Sun, 27 Jan 2019 20:16:43 -0800 (PST) X-Received: by 2002:a9d:177:: with SMTP id 110mr15588936otu.26.1548649003613; Sun, 27 Jan 2019 20:16:43 -0800 (PST) MIME-Version: 1.0 References: <20190117162008.25217-1-stanimir.varbanov@linaro.org> <10deb3d1-2b10-43fe-bc77-4465f561c90a@linaro.org> <80b97fd8-bd3a-df74-c611-5da11bd7adc6@linaro.org> In-Reply-To: <80b97fd8-bd3a-df74-c611-5da11bd7adc6@linaro.org> From: Alexandre Courbot Date: Mon, 28 Jan 2019 13:16:31 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 00/10] Venus stateful Codec API To: Stanimir Varbanov Cc: Linux Media Mailing List , Mauro Carvalho Chehab , Hans Verkuil , LKML , linux-arm-msm@vger.kernel.org, Vikash Garodia , Tomasz Figa , Malathi Gottam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 25, 2019 at 7:35 PM Stanimir Varbanov wrote: > > Hi Alex, > > On 1/25/19 7:34 AM, Alexandre Courbot wrote: > > On Thu, Jan 24, 2019 at 7:13 PM Stanimir Varbanov > > wrote: > >> > >> Hi Alex, > >> > >> Thank you for review and valuable comments! > >> > >> On 1/24/19 10:43 AM, Alexandre Courbot wrote: > >>> Hi Stanimir, > >>> > >>> On Fri, Jan 18, 2019 at 1:20 AM Stanimir Varbanov > >>> wrote: > >>>> > >>>> Hello, > >>>> > >>>> This aims to make Venus decoder compliant with stateful Codec API [1]. > >>>> The patches 1-9 are preparation for the cherry on the cake patch 10 > >>>> which implements the decoder state machine similar to the one in the > >>>> stateful codec API documentation. > >>> > >>> Thanks *a lot* for this series! I am still stress-testing it against > >>> the Chromium decoder tests, but so far it has been rock-solid. I have > >>> a few inline comments on some patches ; I will also want to review the > >>> state machine more thoroughly after refreshing my mind on Tomasz doc, > >>> but this looks pretty promising already. > >> > >> I'm expecting problems with ResetAfterFirstConfigInfo. I don't know why > >> but this test case is very dirty. I'd appreciate any help to decipher > >> what is the sequence of v4l2 calls made by this unittest case. > > > > I did not see any issue with ResetAfterFirstConfigInfo, however > > ResourceExhaustion seems to hang once in a while. But I could already > > see this behavior with the older patchset. > > Is it hangs badly? It just stops processing, no crash. I need to investigate more closely. > > > > In any case I plan to thoroughly review the state machine. I agree it > > is a bit complex to grasp. > > yes the state machine isn't simple and I blamed Tomasz many times for > that :) If I feel inspired I may try to extract the useful part of your patch into a framework that we can use everywhere. :) We don't want every driver to reimplement this complex state machine and introduce new bugs every time.