From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Christian Löhle" <CLoehle@hyperstone.com>
Cc: "jh80.chung@samsung.com" <jh80.chung@samsung.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc: Dont wait for DRTO on Write RSP error
Date: Thu, 23 Sep 2021 20:49:35 +0200 [thread overview]
Message-ID: <CAPDyKFqD=KKgSC1PQz_RVm=sGMWtdFsaHSHDiKDxMKajbkszMA@mail.gmail.com> (raw)
In-Reply-To: <af8f8b8674ba4fcc9a781019e4aeb72c@hyperstone.com>
On Thu, 16 Sept 2021 at 07:59, Christian Löhle <CLoehle@hyperstone.com> wrote:
>
> Only wait for DRTO on reads, otherwise the driver hangs.
>
> The driver prevents sending CMD12 on response errors like CRCs.
> According to the comment this is because some cards have problems
> with this during the UHS tuning sequence.
> Unfortunately this workaround currently also applies for any command
> with data.
> On reads this will set the drto timer which then triggers after a while.
> On writes this will not set any timer and the tasklet will not be
> scheduled again.
> I cannot attest for the UHS workarounds need, but even if so, it should
> at most apply to reads.
> I have observed many hangs when CMD25 response contained a CRC error.
> This patch fixes this without touching the actual UHS tuning workaround.
>
> Signed-off-by: Christian Loehle <cloehle@hyperstone.com>
Applied for next and by adding a stable tag, thanks!
If you don't think we need the stable tag, please tell me.
Kind regards
Uffe
> ---
> drivers/mmc/host/dw_mmc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 6578cc64ae9e..22cf13dc799b 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2081,7 +2081,8 @@ static void dw_mci_tasklet_func(struct tasklet_struct *t)
> * delayed. Allowing the transfer to take place
> * avoids races and keeps things simple.
> */
> - if (err != -ETIMEDOUT) {
> + if (err != -ETIMEDOUT &&
> + host->dir_status == DW_MCI_RECV_STATUS) {
> state = STATE_SENDING_DATA;
> continue;
> }
> --
> 2.32.0
> Hyperstone GmbH | Line-Eid-Strasse 3 | 78467 Konstanz
> Managing Directors: Dr. Jan Peter Berns.
> Commercial register of local courts: Freiburg HRB381782
>
prev parent reply other threads:[~2021-09-23 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210916055929epcas1p2b5cc839886e68a2f2cec17200a2b6d83@epcas1p2.samsung.com>
2021-09-16 5:59 ` [PATCH] mmc: dw_mmc: Dont wait for DRTO on Write RSP error Christian Löhle
2021-09-22 22:52 ` Jaehoon Chung
2021-09-23 4:44 ` Jaehoon Chung
2021-09-23 18:49 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFqD=KKgSC1PQz_RVm=sGMWtdFsaHSHDiKDxMKajbkszMA@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=CLoehle@hyperstone.com \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).