From: Ulf Hansson <ulf.hansson@linaro.org>
To: Jan Glauber <jan.glauber@caviumnetworks.com>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Daney <ddaney@caviumnetworks.com>,
"Steven J . Hill" <Steven.Hill@cavium.com>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs
Date: Mon, 13 Feb 2017 16:45:02 +0100 [thread overview]
Message-ID: <CAPDyKFqMhwt120_J3y293bwMxOEz+LRz6oESfHU0vm8dN0wggQ@mail.gmail.com> (raw)
In-Reply-To: <20170213152408.GB27339@hardcore>
On 13 February 2017 at 16:24, Jan Glauber
<jan.glauber@caviumnetworks.com> wrote:
> On Sun, Feb 12, 2017 at 09:09:29AM +0800, kbuild test robot wrote:
>> Hi Jan,
>>
>> [auto build test ERROR on linus/master]
>> [also build test ERROR on v4.10-rc7 next-20170210]
>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>>
>> url: https://github.com/0day-ci/linux/commits/Jan-Glauber/Cavium-MMC-driver/20170206-214740
>> config: arm64-allmodconfig (attached as .config)
>> compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
>> reproduce:
>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
>> chmod +x ~/bin/make.cross
>> # save the attached .config to linux build tree
>> make.cross ARCH=arm64
>>
>> All errors (new ones prefixed by >>):
>>
>> In file included from drivers/mmc/host/cavium-mmc.c:28:0:
>> drivers/mmc/host/cavium-mmc.h:41:7: warning: "CONFIG_MMC_CAVIUM_THUNDERX" is not defined [-Wundef]
>> #elif CONFIG_MMC_CAVIUM_THUNDERX
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Hi Ulf,
>
> We are aware of this build error, the line above should be:
> #elif IS_ENABLED(CONFIG_MMC_CAVIUM_THUNDERX)
Please avoid using IS_ENABLED() - unless really needed.
Doesn't "#ifdef" work here?
>
> instead of:
> #elif CONFIG_MMC_CAVIUM_THUNDERX
>
> Unless you want it otherwise I'll wait for your review of the series
> and fix this build error with the next revision.
I have started to look at the series (I have comments). So, unless
some other provides you with relevant comments, you can wait for mine
before re-spin.
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2017-02-13 15:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 13:39 [PATCH v11 0/9] Cavium MMC driver Jan Glauber
2017-02-06 13:39 ` [PATCH v11 1/9] dt-bindings: mmc: Add Cavium SOCs MMC bindings Jan Glauber
2017-02-09 0:40 ` Rob Herring
2017-03-03 11:47 ` Ulf Hansson
2017-03-06 11:09 ` Jan Glauber
2017-02-06 13:39 ` [PATCH v11 2/9] mmc: cavium: Add core MMC driver for Cavium SOCs Jan Glauber
2017-03-03 11:47 ` Ulf Hansson
2017-03-03 18:39 ` David Daney
2017-03-07 10:49 ` Jan Glauber
2017-03-08 9:45 ` Ulf Hansson
2017-03-08 17:52 ` Jan Glauber
2017-02-06 13:39 ` [PATCH v11 3/9] mmc: cavium: Add MMC platform driver for Octeon SOCs Jan Glauber
2017-02-06 13:39 ` [PATCH v11 4/9] mmc: cavium: Work-around hardware bug on cn6xxx and cnf7xxx Jan Glauber
2017-02-06 13:39 ` [PATCH v11 5/9] mmc: cavium: Add support for Octeon cn7890 Jan Glauber
2017-02-06 13:39 ` [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Jan Glauber
2017-02-12 1:09 ` kbuild test robot
2017-02-13 15:24 ` Jan Glauber
2017-02-13 15:45 ` Ulf Hansson [this message]
2017-02-15 12:34 ` Arnd Bergmann
2017-02-15 13:54 ` Jan Glauber
2017-02-06 13:39 ` [PATCH v11 7/9] mmc: cavium: Add scatter-gather DMA support Jan Glauber
2017-02-12 1:27 ` kbuild test robot
2017-02-06 13:39 ` [PATCH v11 8/9] mmc: cavium: Support DDR mode for eMMC devices Jan Glauber
2017-02-06 13:39 ` [PATCH v11 9/9] MAINTAINERS: Add entry for Cavium MMC driver Jan Glauber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqMhwt120_J3y293bwMxOEz+LRz6oESfHU0vm8dN0wggQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=Steven.Hill@cavium.com \
--cc=david.daney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=jan.glauber@caviumnetworks.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).