From: Ulf Hansson <ulf.hansson@linaro.org>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>
Subject: Re: [PATCH V1 2/4] mmc: sdhci-msm: Enable MMC_CAP_NEED_RSP_BUSY host capability
Date: Thu, 16 Apr 2020 17:26:24 +0200 [thread overview]
Message-ID: <CAPDyKFrBEoJdJuh9KyBf8MNuAXTy9HCr4GfKPRZpa61FaZHYHA@mail.gmail.com> (raw)
In-Reply-To: <abe9cee2-dce4-c887-cece-5a321e4852bd@codeaurora.org>
On Thu, 16 Apr 2020 at 16:49, Veerabhadrarao Badiganti
<vbadigan@codeaurora.org> wrote:
>
> Hi Ulf,
>
> On 4/16/2020 5:46 PM, Ulf Hansson wrote:
> > On Sun, 12 Apr 2020 at 17:54, Veerabhadrarao Badiganti
> > <vbadigan@codeaurora.org> wrote:
> >> sdhci-msm controller requires the R1B response for commands that
> >> has this response associated with them.
> >>
> >> So enable MMC_CAP_NEED_RSP_BUSY capability.
> > I assume this potentially should be considered as fix and tagged for stable?
> Yes Stable flag can be applied to this.
>
> Patch with MMC_CAP_WAIT_WHILE_BUSY cap also needed besides this.
> Shall I push V2 with stable flag?
Ah, so maybe squash both into one patch to simplify for stable?
Yes, please add a stable tag in v2.
>
> > Another question, if there is there an upper limit of the busy timeout
> > in the HW (cmd->busy_timeout) or does the driver use a software
> > timeout that is adjustable?
>
> The max supported h.w busy timeout value on qcom h/w 21sec.
Alright, that sounds like it should be sufficient for most cases. But
perhaps not for eMMC sanitize.
How do you cope with the situation when the R1B response is passed to
the driver and the cmd->busy_timeout exceeds the 21s?
[...]
Kind regards
Uffe
next prev parent reply other threads:[~2020-04-16 15:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 15:53 [PATCH V1 0/4] Minor fixes to sdhci-msm Veerabhadrarao Badiganti
2020-04-12 15:53 ` [PATCH V1 1/4] mmc: sdhci-msm: Enable MMC_CAP_WAIT_WHILE_BUSY host capability Veerabhadrarao Badiganti
2020-04-16 10:02 ` Adrian Hunter
2020-04-12 15:53 ` [PATCH V1 2/4] mmc: sdhci-msm: Enable MMC_CAP_NEED_RSP_BUSY " Veerabhadrarao Badiganti
2020-04-16 10:02 ` Adrian Hunter
2020-04-16 12:16 ` Ulf Hansson
2020-04-16 14:48 ` Veerabhadrarao Badiganti
2020-04-16 15:26 ` Ulf Hansson [this message]
2020-04-12 15:53 ` [PATCH V1 3/4] mmc: sdhci-msm: Set SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12 quirk Veerabhadrarao Badiganti
2020-04-16 10:03 ` Adrian Hunter
2020-04-12 15:53 ` [PATCH V1 4/4] mmc: sdhci-msm: Enable ADMA length mismatch error interrupt Veerabhadrarao Badiganti
2020-04-12 17:06 ` Veerabhadrarao Badiganti
2020-04-12 17:07 ` [PATCH V1] " Veerabhadrarao Badiganti
2020-04-16 10:05 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFrBEoJdJuh9KyBf8MNuAXTy9HCr4GfKPRZpa61FaZHYHA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).